From: Alex Chiang <achiang@canonical.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
lenb@kernel.org
Subject: Re: [PATCH] acpi: Fall back to manually changing SCI_EN
Date: Tue, 20 Apr 2010 09:00:10 -0600 [thread overview]
Message-ID: <20100420150010.GA17935@canonical.com> (raw)
In-Reply-To: <1271711614-15527-1-git-send-email-mjg@redhat.com>
* Matthew Garrett <mjg@redhat.com>:
> The ACPI spec tells us that the ACPI SCI_EN bit is under hardware control
> and shouldn't be touched by the OS. It seems that the Leading Other OS
> ignores this and some machines expect this behaviour. We have a blacklist
> for these, but given that we're able to detect the failure case and the
> alternative to breaking the spec is letting the machine crash and burn,
> let's try falling back when we know the alternative is a mostly-dead
> machine.
Yes, we got a hint from a Lenovo BIOS developer:
A SCI_EN bit had not been set at S3 resume post. It
should be set as ACPI defines. It seems that Windows OS
sets SCI_EN bit by itself after S3 resume....
So I believe that Matthew's approach is reasonably safe and
correct.
Acked-by: Alex Chiang <achiang@canonical.com>
/ac
next prev parent reply other threads:[~2010-04-20 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 21:13 [PATCH] acpi: Fall back to manually changing SCI_EN Matthew Garrett
2010-04-20 15:00 ` Alex Chiang [this message]
2010-04-20 17:31 ` Rezwanul_Kabir
2010-04-28 18:58 ` Rafael J. Wysocki
2010-04-29 0:22 ` Len Brown
2010-04-29 21:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100420150010.GA17935@canonical.com \
--to=achiang@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox