From: Greg KH <gregkh@suse.de>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
WANG Cong <xiyou.wangcong@gmail.com>, Tejun Heo <tj@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] sysfs: don't use allocated key for lockdep
Date: Tue, 20 Apr 2010 09:23:41 -0700 [thread overview]
Message-ID: <20100420162341.GA3232@suse.de> (raw)
In-Reply-To: <alpine.LRH.2.00.1004201805480.28179@twin.jikos.cz>
On Tue, Apr 20, 2010 at 06:09:27PM +0200, Jiri Kosina wrote:
> On Tue, 20 Apr 2010, Greg KH wrote:
>
> > > lockdep_init_map() {
> > > ......
> > > /*
> > > * Sanity check, the lock-class key must be persistent:
> > > */
> > > if (!static_obj(key)) {
> > > printk("BUG: key %p not in .data!\n", key);
> > > DEBUG_LOCKS_WARN_ON(1);
> > > return;
> > > }
> > > lock->key = key;
> > > ......
> > > }
> > >
> > > Could you please fix it.
> >
> > All in-kernel attributes should now be fixed, so what exactly is the
> > remaining issue?
>
> Are they?
>
> How about my fix to drivers/hwmon/asus_atk0110.c for example, I sent last
> week? http://lkml.org/lkml/2010/4/14/458
Ick, yes, it's still waiting to get sent to Linus, sorry about that,
still catching up on patches :(
thanks,
greg k-h
prev parent reply other threads:[~2010-04-20 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 3:50 [BUG] sysfs: don't use allocated key for lockdep Lai Jiangshan
2010-04-20 13:14 ` Greg KH
2010-04-20 16:09 ` Jiri Kosina
2010-04-20 16:23 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100420162341.GA3232@suse.de \
--to=gregkh@suse.de \
--cc=ebiederm@xmission.com \
--cc=jkosina@suse.cz \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).