From: Joerg Roedel <joerg.roedel@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Greg KH <greg@kroah.com>, Joerg Roedel <joro@8bytes.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: pci_get_dev_by_id() from interrupt handlers
Date: Wed, 21 Apr 2010 12:41:38 +0200 [thread overview]
Message-ID: <20100421104138.GH31537@amd.com> (raw)
In-Reply-To: <1271845271.1776.74.camel@laptop>
On Wed, Apr 21, 2010 at 12:21:11PM +0200, Peter Zijlstra wrote:
> On Wed, 2010-04-21 at 12:05 +0200, Joerg Roedel wrote:
> >
> > > Why not do the whole thing in an interrupt task as the whole thing
> > > sounds like something that shouldn't be done in interrupt context,
> > > right? Now that we have this type of functionality, we should take
> > > advantage of it :)
> >
> > Ok, I think I move the IOMMU interrupt handling to a tasklet.
> >
> tasklet is softirq context, and is not what gregkh was talking about.
>
> You'd still need to change the klist spinlock to be softirq-safe.
Ah right. Thanks for pointing this out. I couldn't find much about the
interrupt tasks. Is it about the request_threaded_irq interface? And
this would be run in the context of a kernel thread, right?
Joerg
next prev parent reply other threads:[~2010-04-21 10:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 16:04 pci_get_dev_by_id() from interrupt handlers Joerg Roedel
2010-04-20 16:32 ` Greg KH
2010-04-20 17:35 ` Joerg Roedel
2010-04-20 17:52 ` Greg KH
2010-04-21 10:05 ` Joerg Roedel
2010-04-21 10:21 ` Peter Zijlstra
2010-04-21 10:41 ` Joerg Roedel [this message]
2010-04-21 10:46 ` Peter Zijlstra
2010-04-21 10:55 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100421104138.GH31537@amd.com \
--to=joerg.roedel@amd.com \
--cc=greg@kroah.com \
--cc=jbarnes@virtuousgeek.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox