From: Andrew Morton <akpm@linux-foundation.org>
To: axel.lin@gmail.com
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Eric Miao <eric.miao@marvell.com>
Subject: Re: [PATCH] max732x: Correct nr_port checking off by one error
Date: Wed, 21 Apr 2010 14:55:52 -0700 [thread overview]
Message-ID: <20100421145552.72307e9c.akpm@linux-foundation.org> (raw)
In-Reply-To: <q2t427d64721004120029n91bb5bcg1416b34dda1a28be@mail.gmail.com>
On Mon, 12 Apr 2010 15:29:16 +0800
Axel Lin <axel.lin@gmail.com> wrote:
> Setup both client_group_a and client_group_b if nr_port > 8 (not
> including nr_port==8).
>
OK, that's what the patch does. But why does it do it?
In other words, when fixing a bug, please include a description of that
bug! And, if it's not obvious from the description, please also describe
the user-visible effects of that bug. So the poor schmuck at the other
end (ie: me) can work out which kernel(s) the fix should be merged
into.
>
> diff --git a/drivers/gpio/max732x.c b/drivers/gpio/max732x.c
> index f786824..51b02c6 100644
> --- a/drivers/gpio/max732x.c
> +++ b/drivers/gpio/max732x.c
> @@ -285,14 +285,14 @@ static int __devinit max732x_probe(struct
> i2c_client *client,
The patch is wordwrapped.
> switch (client->addr & 0x70) {
> case 0x60:
> chip->client_group_a = client;
> - if (nr_port > 7) {
> + if (nr_port > 8) {
And has its tabs replaced with spaces. sorry-youre-using-gmail.
Please see if you can get that fixed up for next time
(Documentation/email-clients.txt has some tips). Worst-case, use
text/plain attachments.
Thanks.
prev parent reply other threads:[~2010-04-21 21:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 7:29 [PATCH] max732x: Correct nr_port checking off by one error Axel Lin
2010-04-21 21:55 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100421145552.72307e9c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=eric.miao@marvell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox