Re: [PATCH V2] blkio: Fix blkio crash during rq stat update

Jens Axboe
2010-04-21T15:48:46Z

On Wed, Apr 21 2010, Vivek Goyal wrote:
> On Wed, Apr 21, 2010 at 05:41:28PM +0200, Jens Axboe wrote:
> > On Wed, Apr 21 2010, Jens Axboe wrote:
> > > On Wed, Apr 21 2010, Vivek Goyal wrote:
> > > > @@ -1001,6 +1002,11 @@ static struct cfq_group *cfq_get_cfqg(struct cfq_data *cfqd, int create)
> > > > return cfqg;
> > > > }
> > > >
> > > > +static inline struct cfq_group *cfq_ref_get_cfqg(struct cfq_group *cfqg) {
> > > > + atomic_inc(&cfqg->ref);
> > > > + return cfqg;
> > > > +}
> > > > +
> > >
> > > Sorry to keep harping on this - style is still wrong, and:
> >
> > I'll fix these up by hand.
>
> Thanks Jens. Sorry for the trouble.

No problem, it's now committed. Thanks for fixing it.

--
Jens Axboe