From: Jens Axboe <jens.axboe@oracle.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
Divyesh Shah <dpshah@google.com>,
Nauman Rafique <nauman@google.com>,
Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Subject: Re: [PATCH V2] blkio: Fix blkio crash during rq stat update
Date: Wed, 21 Apr 2010 17:41:28 +0200 [thread overview]
Message-ID: <20100421154127.GW27497@kernel.dk> (raw)
In-Reply-To: <20100421154101.GV27497@kernel.dk>
On Wed, Apr 21 2010, Jens Axboe wrote:
> On Wed, Apr 21 2010, Vivek Goyal wrote:
> > @@ -1001,6 +1002,11 @@ static struct cfq_group *cfq_get_cfqg(struct cfq_data *cfqd, int create)
> > return cfqg;
> > }
> >
> > +static inline struct cfq_group *cfq_ref_get_cfqg(struct cfq_group *cfqg) {
> > + atomic_inc(&cfqg->ref);
> > + return cfqg;
> > +}
> > +
>
> Sorry to keep harping on this - style is still wrong, and:
I'll fix these up by hand.
--
Jens Axboe
next prev parent reply other threads:[~2010-04-21 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 15:36 [PATCH V2] blkio: Fix blkio crash during rq stat update Vivek Goyal
2010-04-21 15:41 ` Jens Axboe
2010-04-21 15:41 ` Jens Axboe [this message]
2010-04-21 15:47 ` Vivek Goyal
2010-04-21 15:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100421154127.GW27497@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=dpshah@google.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nauman@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox