public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: "Américo Wang" <xiyou.wangcong@gmail.com>,
	"Michal Marek" <mmarek@suse.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: add *.rej pattern to .gitignore
Date: Thu, 22 Apr 2010 00:33:37 +0800	[thread overview]
Message-ID: <20100421163337.GD13861@hack> (raw)
In-Reply-To: <Pine.LNX.4.64.1004211729150.5292@axis700.grange>

On Wed, Apr 21, 2010 at 05:31:34PM +0200, Guennadi Liakhovetski wrote:
>On Wed, 21 Apr 2010, Américo Wang wrote:
>
>> On Wed, Apr 21, 2010 at 01:47:29PM +0200, Guennadi Liakhovetski wrote:
>> >Tell git to ignore .rej files, generated by patch(1).
>> >
>> >Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>> 
>> NACK.
>> 
>> You have to handle *.rej files, not leaving them there.
>
>Hm? I know I have to handle them, and I do handle them, but IMHO it's 
>entirely valid and up to the user to leave them where they are. You could 
>apply similar argument to *.orig or to *~ files. In other words, I'm not 
>convinced.
>

I am not the only people who is against this, there
was a discussion about this before, please search lkml
archive.

Thanks.

  reply	other threads:[~2010-04-21 16:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 11:47 [PATCH] kbuild: add *.rej pattern to .gitignore Guennadi Liakhovetski
2010-04-21 15:28 ` Américo Wang
2010-04-21 15:31   ` Guennadi Liakhovetski
2010-04-21 16:33     ` Américo Wang [this message]
2010-04-21 20:22       ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100421163337.GD13861@hack \
    --to=xiyou.wangcong@gmail.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox