From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754914Ab0DUXPn (ORCPT ); Wed, 21 Apr 2010 19:15:43 -0400 Received: from kroah.org ([198.145.64.141]:54162 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754339Ab0DUXPm (ORCPT ); Wed, 21 Apr 2010 19:15:42 -0400 Date: Wed, 21 Apr 2010 15:39:14 -0700 From: Greg KH To: Mathieu Desnoyers Cc: Steven Rostedt , Randy Dunlap , Greg Kroah-Hartman , Peter Zijlstra , Rusty Russell , linux-kernel@vger.kernel.org, Andrew Morton , Eric Dumazet , Tejun Heo , Ingo Molnar , Linus Torvalds , stable Subject: Re: [stable] [PATCH] modules fix incorrect percpu usage Message-ID: <20100421223914.GA27883@kroah.com> References: <20100330033211.GC7683@Krystal> <20100330033617.GE7683@Krystal> <1269955201.19685.5867.camel@gandalf.stny.rr.com> <20100330135047.GB20673@Krystal> <20100419182822.GH32347@kroah.com> <20100420143457.GB14622@Krystal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100420143457.GB14622@Krystal> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 20, 2010 at 10:34:57AM -0400, Mathieu Desnoyers wrote: > * Greg KH (greg@kroah.com) wrote: > > On Tue, Mar 30, 2010 at 09:50:47AM -0400, Mathieu Desnoyers wrote: > > > * Steven Rostedt (rostedt@goodmis.org) wrote: > > > > On Mon, 2010-03-29 at 23:36 -0400, Mathieu Desnoyers wrote: > > > > > * Mathieu Desnoyers (mathieu.desnoyers@efficios.com) wrote: > > > > > > Should use per_cpu_ptr() to obfuscate the per cpu pointers (RELOC_HIDE is needed > > > > > > for per cpu pointers). > > > > > > > > > > > > Introduced by commit: > > > > > > > > > > > > module.c: commit 6b588c18f8dacfa6d7957c33c5ff832096e752d3 > > > > > > > > > > > > This patch should be queued for the stable branch, for kernels 2.6.29.x to > > > > > > 2.6.33.x. > > > > > > (tested on 2.6.33.1 x86_64) > > > > > > > > > > It's actually needed for mainline too (2.6.34-rc2). > > > > > > > > Then all you need to do is submit it for mainline with a > > > > "Cc: stable@kernel.org" as you did below. It will then automatically be > > > > added to the stable queue when Linus pulls it. > > > > > > OK, thanks for the info. > > > > And I need to wait until it goes into Linus's tree before it can be > > applied to the stable tree. This hasn't happened yet, right? > > > > thanks, > > > > greg k-h > > Same here, for module.c fix. Feel free to choose between this fix or the > corresponding refactoring from Tejun. Thanks, I took this one. greg k-h