From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752989Ab0DVKDM (ORCPT ); Thu, 22 Apr 2010 06:03:12 -0400 Received: from mail-ww0-f46.google.com ([74.125.82.46]:34558 "EHLO mail-ww0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319Ab0DVKDK (ORCPT ); Thu, 22 Apr 2010 06:03:10 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:mime-version :content-type:content-disposition:user-agent; b=NkcHZVSs8TQwBTtxiB//sofI1Aoifvhjzf5MJmztIAQt0tnYczko/3YgtWWg9IQftM YqJ99fRsvvZ2CdcfPRxVCfLFRj3k1g6RYkO+FIhhMuG5FVuffqyiJs8sy+PD51wxEfuG Qs78I8CvJcWk89+xDffZ6KAoLMOk0KIo5IfhU= Date: Thu, 22 Apr 2010 12:00:52 +0200 From: Dan Carpenter To: Greg Kroah-Hartman Cc: Alessio Igor Bogani , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] usb: testing the wrong variable in fs_create_by_name() Message-ID: <20100422100052.GT29647@bicker> Mail-Followup-To: Dan Carpenter , Greg Kroah-Hartman , Alessio Igor Bogani , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a typo here. We should be testing "*dentry" which was just assigned instead of "dentry". This could result in dereferencing an ERR_PTR inside either usbfs_mkdir() or usbfs_create(). Signed-off-by: Dan Carpenter diff --git a/drivers/usb/core/inode.c b/drivers/usb/core/inode.c index 97b40ce..4a6366a 100644 --- a/drivers/usb/core/inode.c +++ b/drivers/usb/core/inode.c @@ -515,13 +515,13 @@ static int fs_create_by_name (const char *name, mode_t mode, *dentry = NULL; mutex_lock(&parent->d_inode->i_mutex); *dentry = lookup_one_len(name, parent, strlen(name)); - if (!IS_ERR(dentry)) { + if (!IS_ERR(*dentry)) { if ((mode & S_IFMT) == S_IFDIR) error = usbfs_mkdir (parent->d_inode, *dentry, mode); else error = usbfs_create (parent->d_inode, *dentry, mode); } else - error = PTR_ERR(dentry); + error = PTR_ERR(*dentry); mutex_unlock(&parent->d_inode->i_mutex); return error;