From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754264Ab0DWAPN (ORCPT ); Thu, 22 Apr 2010 20:15:13 -0400 Received: from kroah.org ([198.145.64.141]:41026 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754171Ab0DWAOp (ORCPT ); Thu, 22 Apr 2010 20:14:45 -0400 Date: Thu, 22 Apr 2010 17:01:06 -0700 From: Greg KH To: Dmitry Torokhov Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] firmware loader: embed device into firmware_priv structure Message-ID: <20100423000106.GC4414@kroah.com> References: <20100314074330.27035.38765.stgit@localhost.localdomain> <20100314074929.27035.80425.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100314074929.27035.80425.stgit@localhost.localdomain> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 13, 2010 at 11:49:29PM -0800, Dmitry Torokhov wrote: > Both these structures have the same lifetime rules so instead of allocating > and managing them separately embed struct device into struct firmware_priv. > Also make sure to delete sysfs attributes ourselves instead of expecting > sysfs to clean up our mess. This one didn't apply due to other changes that have happened to the file since you sent this out. Care to respin it? thanks, greg k-h