From: Greg KH <greg@kroah.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] firmware loader: embed device into firmware_priv structure
Date: Thu, 22 Apr 2010 20:16:49 -0700 [thread overview]
Message-ID: <20100423031649.GB1661@kroah.com> (raw)
In-Reply-To: <20100423001903.GC28213@core.coreip.homeip.net>
On Thu, Apr 22, 2010 at 05:19:03PM -0700, Dmitry Torokhov wrote:
> On Thu, Apr 22, 2010 at 05:01:06PM -0700, Greg KH wrote:
> > On Sat, Mar 13, 2010 at 11:49:29PM -0800, Dmitry Torokhov wrote:
> > > Both these structures have the same lifetime rules so instead of allocating
> > > and managing them separately embed struct device into struct firmware_priv.
> > > Also make sure to delete sysfs attributes ourselves instead of expecting
> > > sysfs to clean up our mess.
> >
> > This one didn't apply due to other changes that have happened to the
> > file since you sent this out. Care to respin it?
> >
>
> I'll wait till next next release, see what's there and resping what's
> missing.
Sounds great.
thanks,
greg k-h
prev parent reply other threads:[~2010-04-23 3:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 7:49 [PATCH 0/5] Assorted patches for firmware loader Dmitry Torokhov
2010-03-14 7:49 ` [PATCH 1/5] firmware loader: use statically initialized data attribute Dmitry Torokhov
2010-04-22 23:51 ` Greg KH
2010-03-14 7:49 ` [PATCH 2/5] firmware loader: rely on driver core to create class attribute Dmitry Torokhov
2010-03-14 7:49 ` [PATCH 3/5] firmware loader: split out builtin firmware handling Dmitry Torokhov
2010-03-14 7:49 ` [PATCH 4/5] firmware loader: do not allocate firmare id separately Dmitry Torokhov
2010-03-14 7:49 ` [PATCH 5/5] firmware loader: embed device into firmware_priv structure Dmitry Torokhov
2010-04-23 0:01 ` Greg KH
2010-04-23 0:19 ` Dmitry Torokhov
2010-04-23 3:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423031649.GB1661@kroah.com \
--to=greg@kroah.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox