From: Paul Mundt <lethal@linux-sh.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Will Deacon <will.deacon@arm.com>,
Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
"K . Prasad" <prasad@linux.vnet.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Jason Wessel <jason.wessel@windriver.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 3/6] hw-breakpoints: Change/Enforce some breakpoints policies
Date: Fri, 23 Apr 2010 17:37:52 +0900 [thread overview]
Message-ID: <20100423083752.GB11770@linux-sh.org> (raw)
In-Reply-To: <1271999639-23605-4-git-send-regression-fweisbec@gmail.com>
On Fri, Apr 23, 2010 at 07:13:56AM +0200, Frederic Weisbecker wrote:
> diff --git a/arch/sh/include/asm/hw_breakpoint.h b/arch/sh/include/asm/hw_breakpoint.h
> index 965dd78..c575cf5 100644
> --- a/arch/sh/include/asm/hw_breakpoint.h
> +++ b/arch/sh/include/asm/hw_breakpoint.h
> @@ -47,7 +47,8 @@ struct pmu;
> #define HBP_NUM 2
>
> /* arch/sh/kernel/hw_breakpoint.c */
> -extern int arch_check_va_in_userspace(unsigned long va, u16 hbp_len);
> +extern int arch_check_bp_in_kernelspace(struct perf_event *bp);
> +extern int arch_validate_hwbkpt_settings(struct perf_event *bp);
> extern int arch_validate_hwbkpt_settings(struct perf_event *bp,
> struct task_struct *tsk);
> extern int hw_breakpoint_exceptions_notify(struct notifier_block *unused,
You forgot to kill off the existing arch_validate_hwbkpt_settings()
definition, so this part at least breaks the build.
next prev parent reply other threads:[~2010-04-23 8:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 5:13 [PATCH 0/6] hw-breakpoints updates Frederic Weisbecker
2010-04-23 5:13 ` [PATCH 1/6] hw-breakpoints: Tag ptrace breakpoint as exclude_kernel Frederic Weisbecker
2010-04-23 5:13 ` [PATCH 2/6] hw-breakpoints: Check disabled breakpoints again Frederic Weisbecker
2010-04-23 5:13 ` [PATCH 3/6] hw-breakpoints: Change/Enforce some breakpoints policies Frederic Weisbecker
2010-04-23 5:21 ` Frederic Weisbecker
2010-04-23 8:37 ` Paul Mundt [this message]
2010-04-23 9:32 ` Paul Mundt
2010-05-01 1:36 ` Frederic Weisbecker
2010-04-23 5:13 ` [PATCH 4/6] hw-breakpoints: Separate constraint space for data and instruction breakpoints Frederic Weisbecker
2010-04-23 5:13 ` [PATCH 5/6] hw-breakpoints: Handle breakpoint weight in allocation constraints Frederic Weisbecker
2010-04-23 5:13 ` [PATCH 6/6] hw-breakpoints: Get the number of available registers on boot dynamically Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423083752.GB11770@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=benh@kernel.crashing.org \
--cc=fweisbec@gmail.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=prasad@linux.vnet.ibm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox