From: Jean Delvare <khali@linux-fr.org>
To: Farid Hammane <farid.hammane@gmail.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
ben-linux@fluff.org, Enrik.Berkhan@ge.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c-algo-pca: fix all coding style issues in i2c-algo-pca.c
Date: Fri, 23 Apr 2010 10:13:56 +0200 [thread overview]
Message-ID: <20100423101356.454abdd6@hyperion.delvare> (raw)
In-Reply-To: <201004222330.34660.farid.hammane@gmail.com>
Hi Farid,
On Thu, 22 Apr 2010 23:30:34 +0200, Farid Hammane wrote:
> Hi Jean and Wolfram,
>
> On Thursday 22 April 2010 09:59:37 you wrote:
> > On Thu, Apr 22, 2010 at 09:25:24AM +0200, Jean Delvare wrote:
> > > On Thu, 22 Apr 2010 01:57:38 +0200, Wolfram Sang wrote:
> > > > Hi Farid,
> > > >
> > > > thanks for this approach. Have you checked that the binary is the same
> > > > before/after your patch? If so, please mention in your patch
> > > > description.
>
> Ok, I think that nothing can be broken with this kind of patch. I just built
> i2c-algo-pca.c and everything was ok.
>
> For further patchs I will mention that it has been tested. Thanks for the
> advice !
It's not just a matter of building it. When you only fix coding style
issue, the binary object before and after your patch should be exactly
the same. It's a good idea to verify this, especially for drivers you
aren't using yourself.
--
Jean Delvare
prev parent reply other threads:[~2010-04-23 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 19:11 [PATCH] i2c-algo-pca: fix all coding style issues in i2c-algo-pca.c Farid Hammane
2010-04-21 23:57 ` Wolfram Sang
2010-04-22 7:25 ` Jean Delvare
2010-04-22 7:59 ` Wolfram Sang
2010-04-22 21:30 ` Farid Hammane
2010-04-23 8:13 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423101356.454abdd6@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=Enrik.Berkhan@ge.com \
--cc=ben-linux@fluff.org \
--cc=farid.hammane@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox