From: Andrew Morton <akpm@linux-foundation.org>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Miklos Szeredi <mszeredi@suse.cz>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH] procfs: fix tid fdinfo
Date: Fri, 23 Apr 2010 11:16:20 -0700 [thread overview]
Message-ID: <20100423111620.100840fe.akpm@linux-foundation.org> (raw)
In-Reply-To: <4BD1BF57.7070201@redhat.com>
On Fri, 23 Apr 2010 17:40:07 +0200
Jerome Marchand <jmarchan@redhat.com> wrote:
> Correct the file_operations struct in fdinfo entry of tid_base_stuff[].
>
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
> ---
> base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/proc/base.c b/fs/proc/base.c
> index 7621db8..8418fcc 100644
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -2909,7 +2909,7 @@ out_no_task:
> */
> static const struct pid_entry tid_base_stuff[] = {
> DIR("fd", S_IRUSR|S_IXUSR, proc_fd_inode_operations, proc_fd_operations),
> - DIR("fdinfo", S_IRUSR|S_IXUSR, proc_fdinfo_inode_operations, proc_fd_operations),
> + DIR("fdinfo", S_IRUSR|S_IXUSR, proc_fdinfo_inode_operations, proc_fdinfo_operations),
> REG("environ", S_IRUSR, proc_environ_operations),
> INF("auxv", S_IRUSR, proc_pid_auxv),
> ONE("status", S_IRUGO, proc_pid_status),
hm, the code's been like that for over a year. What are the
user-visible effects of the bug, and of this change?
next prev parent reply other threads:[~2010-04-23 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 15:40 [PATCH] procfs: fix tid fdinfo Jerome Marchand
2010-04-23 18:16 ` Andrew Morton [this message]
2010-04-24 19:27 ` Alexey Dobriyan
2010-04-23 20:07 ` Miklos Szeredi
2010-04-26 7:49 ` Jerome Marchand
2010-04-26 10:26 ` Miklos Szeredi
2010-04-24 16:28 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423111620.100840fe.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@suse.cz \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox