From: Joerg Roedel <joerg.roedel@amd.com>
To: Alexander Graf <agraf@suse.de>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] KVM: SVM: Fix nested nmi handling
Date: Fri, 23 Apr 2010 16:31:59 +0200 [thread overview]
Message-ID: <20100423143159.GJ31537@amd.com> (raw)
In-Reply-To: <013159C3-277C-447C-B64B-D2196AF851F9@suse.de>
On Fri, Apr 23, 2010 at 04:24:54PM +0200, Alexander Graf wrote:
>
> On 23.04.2010, at 16:22, Joerg Roedel wrote:
> > No, nested_svm_nmi runs in atomic context where we can't emulate a
> > vmexit. We set exit_required and emulate the vmexit later.
>
> So we modify the L2 rflags and then trigger a #vmexit, leaving the l2
> state broken?
No, the rflags are changed in enable_nmi_window which isn't called when
we run nested and the nested hypervisor intercepts nmi. So it only runs
in the !nested case where it can't corrupt L2 state.
Joerg
next prev parent reply other threads:[~2010-04-23 14:32 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 10:33 [PATCH 0/8] More fixes for nested svm Joerg Roedel
2010-04-22 10:33 ` [PATCH 1/8] KVM: SVM: Fix nested nmi handling Joerg Roedel
2010-04-23 13:46 ` Alexander Graf
2010-04-23 14:13 ` Joerg Roedel
2010-04-23 14:19 ` Alexander Graf
2010-04-23 14:22 ` Joerg Roedel
2010-04-23 14:24 ` Alexander Graf
2010-04-23 14:31 ` Joerg Roedel [this message]
2010-04-23 14:42 ` Alexander Graf
2010-04-23 14:51 ` Joerg Roedel
2010-04-23 19:18 ` Alexander Graf
2010-04-22 10:33 ` [PATCH 2/8] KVM: SVM: Make sure rip is synced to vmcb before nested vmexit Joerg Roedel
2010-04-22 10:33 ` [PATCH 3/8] KVM: SVM: Sync cr0 and cr3 to kvm state before nested handling Joerg Roedel
2010-04-23 13:50 ` Alexander Graf
2010-04-23 14:17 ` Joerg Roedel
2010-04-23 14:20 ` Alexander Graf
2010-04-22 10:33 ` [PATCH 4/8] KVM: SVM: Propagate nested entry failure into guest hypervisor Joerg Roedel
2010-04-23 13:50 ` Alexander Graf
2010-04-22 10:33 ` [PATCH 5/8] KVM: X86: Add callback to let modules decide over some supported cpuid bits Joerg Roedel
2010-04-23 13:52 ` Alexander Graf
2010-04-23 13:59 ` Avi Kivity
2010-04-22 10:33 ` [PATCH 6/8] KVM: SVM: Report emulated SVM features to userspace Joerg Roedel
2010-04-23 13:55 ` Alexander Graf
2010-04-23 14:21 ` Joerg Roedel
2010-04-22 10:33 ` [PATCH 7/8] KVM: x86: Allow marking an exception as reinjected Joerg Roedel
2010-04-23 13:57 ` Alexander Graf
2010-04-23 14:27 ` Joerg Roedel
2010-04-23 14:41 ` Alexander Graf
2010-04-22 10:33 ` [PATCH 8/8] KVM: SVM: Handle MCE intercepts always on host level Joerg Roedel
2010-04-23 13:58 ` Alexander Graf
2010-04-23 14:28 ` Joerg Roedel
2010-04-22 11:04 ` [PATCH 0/8] More fixes for nested svm Avi Kivity
2010-04-23 13:47 ` Alexander Graf
2010-04-23 19:18 ` Alexander Graf
2010-04-23 13:43 ` Alexander Graf
2010-04-25 8:39 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423143159.GJ31537@amd.com \
--to=joerg.roedel@amd.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox