From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756308Ab0DWPFI (ORCPT ); Fri, 23 Apr 2010 11:05:08 -0400 Received: from cantor.suse.de ([195.135.220.2]:33178 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754751Ab0DWPFA (ORCPT ); Fri, 23 Apr 2010 11:05:00 -0400 Date: Fri, 23 Apr 2010 08:05:28 -0700 From: Greg KH To: Mark Brown Cc: Greg KH , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org Subject: Re: platform_bus: Allow runtime PM by default Message-ID: <20100423150528.GB7648@suse.de> References: <1269625370-17754-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20100422235353.GA16310@kroah.com> <20100423105750.GA27232@rakim.wolfsonmicro.main> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100423105750.GA27232@rakim.wolfsonmicro.main> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 23, 2010 at 11:57:51AM +0100, Mark Brown wrote: > On Thu, Apr 22, 2010 at 04:53:53PM -0700, Greg KH wrote: > > On Fri, Mar 26, 2010 at 05:42:50PM +0000, Mark Brown wrote: > > > > Change the default implementation to the standard pm_generic_runtime > > > one, allowing drivers to use runtime PM without per-architecture > > > changes. > > > That's nice, but it breaks the build on my system: > > CC drivers/base/platform.o > > drivers/base/platform.c: In function ???platform_pm_runtime_suspend???: > > drivers/base/platform.c:970: error: implicit declaration of function ???pm_generic_runtime_suspend??? > > drivers/base/platform.c: In function ???platform_pm_runtime_resume???: > > drivers/base/platform.c:975: error: implicit declaration of function ???pm_generic_runtime_resume??? > > drivers/base/platform.c: In function ???platform_pm_runtime_idle???: > > drivers/base/platform.c:980: error: implicit declaration of function ???pm_generic_runtime_idle??? > > make[1]: *** [drivers/base/platform.o] Error 1 > > make: *** [_module_drivers/base] Error 2 > > > Care to fix it up? > > This depends on "PM: Provide generic subsystem-level callbacks" which is > in Linus' tree - which kernel version are you building against and with > what config? Things work fine for me in -next... I was using Linus's latest tree as of yesterday when this failed. Are you relying on something in -next that is not in Linus's tree? thanks, greg k-h