From: tytso@mit.edu
To: Pavel Machek <pavel@ucw.cz>
Cc: Arve Hj??nnev??g <arve@android.com>,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Randy Dunlap <rdunlap@xenotime.net>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Magnus Damm <damm@igel.co.jp>,
Nigel Cunningham <nigel@tuxonice.net>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/9] PM: suspend_block: Add driver to access suspend blockers from user-space
Date: Fri, 23 Apr 2010 21:53:34 -0400 [thread overview]
Message-ID: <20100424015334.GO14986@thunk.org> (raw)
In-Reply-To: <20100423084349.GC1573@ucw.cz>
On Fri, Apr 23, 2010 at 10:43:49AM +0200, Pavel Machek wrote:
> > +To create a suspend_blocker from user-space, open the suspend_blocker device:
> > + fd = open("/dev/suspend_blocker", O_RDWR | O_CLOEXEC);
> > +then call:
> > + ioctl(fd, SUSPEND_BLOCKER_IOCTL_INIT(strlen(name)), name);
>
>
> This seems like very wrong idea -- it uses different ioctl number for
> each length AFAICT.
Yep, and there's nothing wrong with that IMHO. It's a clever use of
the _IOC encoding scheme.
- Ted
next prev parent reply other threads:[~2010-04-24 2:26 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 1:08 [PATCH 0/9] Suspend block api (version 4) Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 1/9] PM: Add suspend block api Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 2/9] PM: suspend_block: Add driver to access suspend blockers from user-space Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 3/9] PM: suspend_block: Abort task freezing if a suspend_blocker is active Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 4/9] PM: suspend_block: Switch to list of active and inactive suspend blockers Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 5/9] PM: suspend_block: Add debugfs file Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 6/9] PM: suspend_block: Add suspend_blocker stats Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 7/9] PM: Add suspend blocking work Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 8/9] Input: Block suspend while event queue is not empty Arve Hjønnevåg
2010-04-23 1:08 ` [PATCH 9/9] power_supply: Block suspend while power supply change notifications are pending Arve Hjønnevåg
2010-04-23 20:56 ` [PATCH 8/9] Input: Block suspend while event queue is not empty Randy Dunlap
2010-04-23 21:08 ` Dmitry Torokhov
2010-04-24 5:02 ` Arve Hjønnevåg
2010-04-24 14:36 ` [linux-pm] " Alan Stern
2010-04-25 2:30 ` Rafael J. Wysocki
2010-04-25 15:29 ` Alan Stern
2010-04-25 22:41 ` Arve Hjønnevåg
2010-04-24 4:58 ` Arve Hjønnevåg
2010-04-23 8:16 ` [PATCH 7/9] PM: Add suspend blocking work Tejun Heo
2010-04-23 12:20 ` Oleg Nesterov
2010-04-23 22:49 ` Arve Hjønnevåg
2010-04-24 5:21 ` Arve Hjønnevåg
2010-04-24 6:33 ` Tejun Heo
2010-04-24 7:21 ` Arve Hjønnevåg
2010-04-24 7:43 ` Tejun Heo
2010-04-26 14:06 ` Oleg Nesterov
2010-04-23 20:58 ` [PATCH 5/9] PM: suspend_block: Add debugfs file Randy Dunlap
2010-04-24 3:23 ` Arve Hjønnevåg
2010-04-24 4:24 ` Randy Dunlap
2010-04-24 4:54 ` Arve Hjønnevåg
2010-04-25 18:15 ` Greg KH
2010-04-25 19:53 ` Randy Dunlap
2010-04-26 0:00 ` tytso
2010-04-26 0:23 ` Randy Dunlap
2010-04-26 0:45 ` tytso
2010-04-26 0:50 ` Randy Dunlap
2010-04-26 1:39 ` [linux-pm] " Alan Stern
2010-04-26 6:24 ` Brian Swetland
2010-04-26 13:28 ` Randy Dunlap
2010-04-23 2:25 ` [linux-pm] [PATCH 2/9] PM: suspend_block: Add driver to access suspend blockers from user-space Matt Helsley
2010-04-23 3:54 ` Arve Hjønnevåg
2010-04-23 4:38 ` Greg KH
2010-04-23 8:43 ` Pavel Machek
2010-04-23 16:43 ` [linux-pm] " Alan Stern
2010-04-24 3:20 ` Arve Hjønnevåg
2010-04-24 5:55 ` Pavel Machek
2010-04-24 14:44 ` Alan Stern
2010-04-25 22:34 ` Arve Hjønnevåg
2010-04-26 19:25 ` Alan Stern
2010-04-27 4:04 ` Arve Hjønnevåg
2010-04-27 18:33 ` Alan Stern
2010-04-27 22:03 ` Rafael J. Wysocki
2010-04-27 23:22 ` Arve Hjønnevåg
2010-04-24 1:53 ` tytso [this message]
2010-04-24 5:39 ` Pavel Machek
2010-04-23 16:33 ` [PATCH 1/9] PM: Add suspend block api Alan Stern
2010-04-23 16:45 ` [linux-pm] " Alan Stern
2010-04-24 2:15 ` Arve Hjønnevåg
2010-04-24 2:30 ` Alan Stern
2010-04-24 3:14 ` Arve Hjønnevåg
2010-04-23 4:39 ` [linux-pm] [PATCH 0/9] Suspend block api (version 4) Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100424015334.GO14986@thunk.org \
--to=tytso@mit.edu \
--cc=arve@android.com \
--cc=cornelia.huck@de.ibm.com \
--cc=damm@igel.co.jp \
--cc=jbarnes@virtuousgeek.org \
--cc=len.brown@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=nigel@tuxonice.net \
--cc=pavel@ucw.cz \
--cc=rdunlap@xenotime.net \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox