From: Greg KH <greg@kroah.com>
To: Tomas Winkler <tomasw@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Kay Sievers <kay.sievers@vrfy.org>,
David Woodhouse <dwmw2@infradead.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Emmanuel Grumbach <egrumbach@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: request_firmware API exhaust memory
Date: Sun, 25 Apr 2010 12:36:58 -0700 [thread overview]
Message-ID: <20100425193658.GA24039@kroah.com> (raw)
In-Reply-To: <o2n1ba2fa241004251222x6ab49726p9757fd8be4952bee@mail.gmail.com>
On Sun, Apr 25, 2010 at 10:22:54PM +0300, Tomas Winkler wrote:
> On Sun, Apr 25, 2010 at 7:37 PM, Greg KH <greg@kroah.com> wrote:
> > On Thu, Apr 22, 2010 at 01:22:51AM +0300, Tomas Winkler wrote:
> >> On Mon, Apr 19, 2010 at 5:59 PM, Greg KH <greg@kroah.com> wrote:
> >> > On Mon, Apr 19, 2010 at 03:20:34PM +0300, Tomas Winkler wrote:
> >> >> Lately we've been developing a device that rather more extensively
> >> >> used request_firmware API in load and also using pm_notifiers to load
> >> >> firmware.
> >> >
> >> > Do you have a pointer to your driver source anywhere that shows how you
> >> > are trying to use the firmware api in this manner?
> >>
> >> I've attached a very simple ??test driver I'm using. ??Just wanted to
> >> eliminate anything else.
> >> Bellow is a little script that loads and releases the firmware. My
> >> previous observation was wrong.
> >> The free memory gradually decreases regardless of number or dangling
> >> udevd forks, which are eventually collected if the sleep period is
> >> long enough ~10s.
> >
> > That sounds normal for the free memory. ??Kay, that's also to be expected
> > for the udevd forks as well, right?
>
> Sorry maybe I was not clear what I mean that the memory will be
> eventually exhausted and system will crash
> Is this normal?
Ah, no, that's not normal. Have you run kmemleak on your module (or
test module) to verify that you are properly freeing up the memory?
> Actually I less suspect now udevd as the same happens on android
> platform where there is no udev
Which is a sad thing for a whole other range of issues...
thanks,
greg k-h
next prev parent reply other threads:[~2010-04-25 19:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 12:20 request_firmware API exhaust memory Tomas Winkler
2010-04-19 12:35 ` Kay Sievers
2010-04-19 14:59 ` Greg KH
2010-04-21 22:22 ` Tomas Winkler
2010-04-25 16:37 ` Greg KH
2010-04-25 19:22 ` Tomas Winkler
2010-04-25 19:36 ` Greg KH [this message]
2010-04-25 20:09 ` Tomas Winkler
2010-04-26 10:38 ` Kay Sievers
2010-04-26 15:19 ` Kay Sievers
2010-04-26 16:59 ` Tomas Winkler
2010-04-27 4:12 ` Sujith Manoharan
2010-04-27 11:18 ` Tomas Winkler
2010-04-27 11:53 ` Tomas Winkler
2010-04-27 12:05 ` Kay Sievers
2010-04-27 12:43 ` David Woodhouse
2010-04-27 13:34 ` Kay Sievers
2010-04-28 8:23 ` Kay Sievers
2010-04-28 13:07 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100425193658.GA24039@kroah.com \
--to=greg@kroah.com \
--cc=dwmw2@infradead.org \
--cc=egrumbach@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox