Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal

[Frederic Weisbecker <fweisbec@gmail.com>]

On Mon, Apr 26, 2010 at 03:32:51PM -0700, Linus Torvalds wrote:
> 
> 
> On Tue, 27 Apr 2010, Frederic Weisbecker wrote:
> > 
> > I've queued it for the next merge window in
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
> > 	bkl/ioctl
> 
> Btw, I hope you took the second version, that had the two additional fixes 
> from Arnd (and my expansion of his fix to au1550_ac97.c).


Yeah.


 
> Looking at the arch code, I doubt there are any big architecture-specific 
> things. But there could easily be some other drivers like au1550_ac97.c 
> that only get enabled on certain architectures and missed the grepping for 
> some reason.
> 
> That said, because of Arnd's fix, I did end up grepping for 
> 'file_operations' and old-style gcc initializers (ie "ioctl: xyz" rather 
> than the proper ".ioctl = xyz"), and the grep came up empty.
> 
> But it's possible that there's something hiding: with all of serial, 
> bluetooth, block drivers, sound, socket proto's and v4l2 each having their 
> own 'ioctl' pointers, it's not entirely trivial to grep for it all and be 
> sure..
> 
> So there might be one or two cases still hiding, but it looks unlikely. 
> And I'm almost certain that it definitely isn't more than just one or two.


Ok, thanks.