Re: [PATCH] added S6E63M0 AMOLED LCD Panel driver.

Andrew Morton
2010-03-30T23:03:19Z

On Fri, 26 Mar 2010 12:24:24 +0900
InKi Dae <daeinki@gmail.com> wrote:

> +static int s6e63m0_ldi_init(struct s6e63m0 *lcd)
> +{
> + int ret;
> +
> + ret = s6e63m0_panel_send_sequence(lcd, SEQ_PANEL_CONDITION_SET);
> + ret |= s6e63m0_panel_send_sequence(lcd, SEQ_DISPLAY_CONDITION_SET);
> + ret |= s6e63m0_panel_send_sequence(lcd, SEQ_GAMMA_SETTING);
> + ret |= s6e63m0_panel_send_sequence(lcd, SEQ_ETC_CONDITION_SET);
> + ret |= s6e63m0_panel_send_sequence(lcd, SEQ_ACL_ON);
> + ret |= s6e63m0_panel_send_sequence(lcd, SEQ_ELVSS_ON);
> +
> + return ret;
> +}

Well. If one call to s6e63m0_panel_send_sequence() returns -ENOMEM and
another call returns -EIO (for example), this function will return some
other, incorrect errno.

Which is a rather minor problem, unless some caller is explicitly
looking for some particular error code, which doesn't happen often.