From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Valdis.Kletnieks@vt.edu
Cc: mingo@redhat.com, hpa@zytor.com, paulus@samba.org,
linux-kernel@vger.kernel.org, tzanussi@gmail.com,
a.p.zijlstra@chello.nl, fweisbec@gmail.com,
stefanha@linux.vnet.ibm.com, tglx@linutronix.de,
mhiramat@redhat.com, mingo@elte.hu,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf tools: Fix libdw-dev package name in error message
Date: Tue, 27 Apr 2010 12:00:16 -0300 [thread overview]
Message-ID: <20100427150016.GC8565@ghostprotocols.net> (raw)
In-Reply-To: <5694.1272376100@localhost>
Em Tue, Apr 27, 2010 at 09:48:20AM -0400, Valdis.Kletnieks@vt.edu escreveu:
> On Tue, 27 Apr 2010 12:59:19 -0000, tip-bot for Stefan Hajnoczi said:
> > Commit-ID: f93830fbb06b67848c762f2177c06cc3cbb97deb
> > Gitweb: http://git.kernel.org/tip/f93830fbb06b67848c762f2177c06cc3cbb97deb
> > Author: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> > AuthorDate: Mon, 26 Apr 2010 15:39:54 -0300
> > Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
> > CommitDate: Mon, 26 Apr 2010 15:39:54 -0300
> >
> > perf tools: Fix libdw-dev package name in error message
> >
> > The headers required for DWARF support are provided by the libdw-dev
> > package in Debian-based distros.
>
> Not all the world is Debian based. As I mentioned before, the package needed
> is elfutils-devel on Redhat/Fedora systesm. For those boxes, you're changing a
> 'elfutil-dev' that the user can guess is supposed to be -devel, to a package
> that doesn't exist on Redhat/Fedora. And to compound it, if the user guesses
> that you meant libdwarf-devel, that still fails, because that does *not*
> provide the libdw.h header - that's still in elfutil-devel.
It works for Red Hat, the message is:
msg := $(warning No libdw.h found or old libdw.h found, disables dwarf support. Please install elfutils-devel/libdw-dev);
And, as you say:
[acme@doppio git]$ rpm -ql elfutils-devel
/usr/include/dwarf.h
/usr/include/elfutils
/usr/include/elfutils/elf-knowledge.h
/usr/include/elfutils/libasm.h
/usr/include/elfutils/libdw.h
/usr/include/elfutils/libdwfl.h
/usr/include/elfutils/libebl.h
/usr/include/elfutils/version.h
/usr/lib64/libasm.so
/usr/lib64/libdw.so
/usr/lib64/libebl.a
[acme@doppio git]$
If you have a better phrasing to avoid such misunderstandings,
please send a patch.
- Arnaldo
next prev parent reply other threads:[~2010-04-27 15:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 14:27 [PATCH] perf: Fix libdw-dev package name in error message Stefan Hajnoczi
2010-04-26 16:13 ` Arnaldo Carvalho de Melo
2010-04-26 16:32 ` Valdis.Kletnieks
2010-04-27 12:59 ` [tip:perf/core] perf tools: " tip-bot for Stefan Hajnoczi
2010-04-27 13:48 ` Valdis.Kletnieks
2010-04-27 15:00 ` Arnaldo Carvalho de Melo [this message]
2010-04-27 21:57 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427150016.GC8565@ghostprotocols.net \
--to=acme@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox