public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: linux-kernel@vger.kernel.org, Anton Vorontsov <cbou@mail.ru>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] tosa_battery: fix FTBFS bug due to driver_data access
Date: Tue, 27 Apr 2010 15:48:35 -0700	[thread overview]
Message-ID: <20100427154835.27bdc233.akpm@linux-foundation.org> (raw)
In-Reply-To: <1272374302-9506-1-git-send-email-dbaryshkov@gmail.com>

On Tue, 27 Apr 2010 17:18:22 +0400
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> wrote:

> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
>  drivers/power/tosa_battery.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Please don't send unchangelogged patches.

Please don't send patches which require recipients to go googling
acronyms to work out wtf you're up to.

<googles the acronym>

Ah, it appears to be a build fix.

Please always quote the compiler errors when fixing a build error.

IOW: bah.


  reply	other threads:[~2010-04-27 22:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27 13:18 [PATCH] tosa_battery: fix FTBFS bug due to driver_data access Dmitry Eremin-Solenikov
2010-04-27 22:48 ` Andrew Morton [this message]
2010-04-30 18:13   ` [PATCH] Remove tosa_battery driver (was: Re: [PATCH] tosa_battery: fix FTBFS bug due to driver_data access) Anton Vorontsov
2010-04-30 20:40     ` Dmitry Eremin-Solenikov
2010-05-02 20:12       ` Anton Vorontsov
2010-05-02 20:52         ` Dmitry Eremin-Solenikov
2010-05-04 14:56           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100427154835.27bdc233.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=cbou@mail.ru \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox