From: Frederic Weisbecker <fweisbec@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>, Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
David Miller <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH] lockdep: Fix redundant_hardirqs_on incremented with irqs enabled
Date: Tue, 27 Apr 2010 20:07:56 +0200 [thread overview]
Message-ID: <20100427180749.GB5586@nowhere> (raw)
In-Reply-To: <20100427173227.7ec29329.sfr@canb.auug.org.au>
On Tue, Apr 27, 2010 at 05:32:27PM +1000, Stephen Rothwell wrote:
> Hi Frederic,
>
> On Thu, 15 Apr 2010 15:37:50 +0200 Frederic Weisbecker <fweisbec@gmail.com> wrote:
> >
> > When a path restore the flags while irqs are already enabled, we
> > update the per cpu var redundant_hardirqs_on in a racy fashion
> > and debug_atomic_inc() warns about this situation.
> >
> > In this particular case, we need to explictly disable the irqs before
> > updating this stat var in order to update it safely.
> >
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: David Miller <davem@davemloft.net>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > ---
> > kernel/lockdep.c | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
>
> Ping? Any movement on this?
Ingo, if you have no problems with these two patches, could you please
apply them?
Thanks.
next prev parent reply other threads:[~2010-04-27 18:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 6:12 linux-next: boot failure after merge of the final tree (tip related) Stephen Rothwell
2010-04-15 6:48 ` Benjamin Herrenschmidt
2010-04-15 6:49 ` linux-next: PowerPC WARN_ON_ONCE() " Ingo Molnar
2010-04-15 6:55 ` David Miller
2010-04-15 7:32 ` Ingo Molnar
2010-04-16 1:51 ` Benjamin Herrenschmidt
2010-04-16 1:56 ` Benjamin Herrenschmidt
2010-04-15 10:04 ` Stephen Rothwell
2010-04-15 13:37 ` [PATCH] lockdep: Fix redundant_hardirqs_on incremented with irqs enabled Frederic Weisbecker
2010-04-27 7:32 ` Stephen Rothwell
2010-04-27 18:07 ` Frederic Weisbecker [this message]
2010-04-28 7:12 ` Stephen Rothwell
2010-04-15 13:00 ` linux-next: PowerPC WARN_ON_ONCE() after merge of the final tree (tip related) Frederic Weisbecker
2010-04-15 14:03 ` Ingo Molnar
2010-04-15 17:15 ` Frederic Weisbecker
2010-04-16 10:38 ` Peter Zijlstra
2010-04-16 12:32 ` Frederic Weisbecker
2010-04-15 17:24 ` Frederic Weisbecker
2010-04-15 17:39 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427180749.GB5586@nowhere \
--to=fweisbec@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox