[PATCH] Staging: comedi: fixes the checkpatch error in skel.c This is a patch to the skel.c file that fixes the 80 line exceeding warning and the printk warning found by chekpatch.pl tool Signed-off-by: Jacob S David <jacobselvin@gmail.com>

[PATCH] Staging: comedi: fixes the checkpatch error in skel.c This is a patch to the skel.c file that fixes the 80 line exceeding warning and the printk warning found by chekpatch.pl tool Signed-off-by: Jacob S David <jacobselvin@gmail.com>

[jsd_syd]

From: Jacob David <jacobselvin@gmail.com>

---
 drivers/staging/comedi/drivers/skel.c |   25 ++++++++++++++++---------
 1 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/comedi/drivers/skel.c b/drivers/staging/comedi/drivers/skel.c
index aba57d9..58658b0 100644
--- a/drivers/staging/comedi/drivers/skel.c
+++ b/drivers/staging/comedi/drivers/skel.c
@@ -130,8 +130,10 @@ MODULE_DEVICE_TABLE(pci, skel_pci_table);
 #define thisboard ((const struct skel_board *)dev->board_ptr)
 
 /* this structure is for data unique to this hardware driver.  If
-   several hardware drivers keep similar information in this structure,
-   feel free to suggest moving the variable to the struct comedi_device struct.  */
+ * several hardware drivers keep similar information in this structure,
+ * feel free to suggest moving the variable to the struct comedi_device
+ * struct.
+ */
 struct skel_private {
 
 	int data;
@@ -211,7 +213,7 @@ static int skel_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 {
 	struct comedi_subdevice *s;
 
-	printk("comedi%d: skel: ", dev->minor);
+	printk(KERN_INFO "comedi%d: skel: ", dev->minor);
 
 /*
  * If you can probe the device to determine what device in a series
@@ -297,7 +299,7 @@ static int skel_attach(struct comedi_device *dev, struct comedi_devconfig *it)
  */
 static int skel_detach(struct comedi_device *dev)
 {
-	printk("comedi%d: skel: remove\n", dev->minor);
+	printk(KERN_INFO "comedi%d: skel: remove\n", dev->minor);
 
 	return 0;
 }
@@ -336,7 +338,7 @@ static int skel_ai_rinsn(struct comedi_device *dev, struct comedi_subdevice *s,
 		if (i == TIMEOUT) {
 			/* printk() should be used instead of printk()
 			 * whenever the code can be called from real-time. */
-			printk("timeout\n");
+			printk(KERN_INFO "timeout\n");
 			return -ETIMEDOUT;
 		}
 
@@ -397,7 +399,9 @@ static int skel_ai_cmdtest(struct comedi_device *dev,
 	if (err)
 		return 1;
 
-	/* step 2: make sure trigger sources are unique and mutually compatible */
+	/* step 2: make sure trigger sources are unique and mutually
+	 * compatible
+	 */
 
 	/* note that mutual compatibility is not an issue here */
 	if (cmd->scan_begin_src != TRIG_TIMER &&
@@ -529,7 +533,7 @@ static int skel_ao_winsn(struct comedi_device *dev, struct comedi_subdevice *s,
 	int i;
 	int chan = CR_CHAN(insn->chanspec);
 
-	printk("skel_ao_winsn\n");
+	printk(KERN_INFO "skel_ao_winsn\n");
 	/* Writing a list of values to an AO channel is probably not
 	 * very useful, but that's how the interface is defined. */
 	for (i = 0; i < insn->n; i++) {
@@ -623,6 +627,9 @@ static int skel_dio_insn_config(struct comedi_device *dev,
  * as necessary.
  */
 COMEDI_INITCLEANUP(driver_skel);
-/* If you are writing a PCI driver you should use COMEDI_PCI_INITCLEANUP instead.
-*/
+/* If you are writing a PCI driver you should use COMEDI_PCI_INITCLEANUP
+ * instead.
+ */
+
 /* COMEDI_PCI_INITCLEANUP(driver_skel, skel_pci_table) */
+
-- 
1.6.3.3

Re: Staging: comedi: fixes the checkpatch error in skel.c

[Greg KH]

On Sat, Mar 13, 2010 at 01:51:34PM +1100, Jacob David wrote:
> From: Jacob David <jacobselvin@gmail.com>
> 
> This is a patch to the skel.c file that fixes the 80 line exceeding
> warning and the printk warning found by chekpatch.pl tool

Sorry, but someone already sent in a patch to do this same thing.

greg k-h