public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: roland@redhat.com, oleg@redhat.com
Cc: akpm@linux-foundation.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2]: mark ptrace_traceme static
Date: Wed, 28 Apr 2010 13:45:41 +0200	[thread overview]
Message-ID: <20100428114541.GA4705@lst.de> (raw)
In-Reply-To: <20100201191855.GA11874@lst.de>

Any reason this never made it to Linus?

On Mon, Feb 01, 2010 at 08:18:55PM +0100, Christoph Hellwig wrote:
> It's not used outside of ptrace.c, so no need to allow access to it.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: linux-2.6/include/linux/ptrace.h
> ===================================================================
> --- linux-2.6.orig/include/linux/ptrace.h	2010-01-26 18:02:46.745004926 +0100
> +++ linux-2.6/include/linux/ptrace.h	2010-01-26 18:02:51.759268161 +0100
> @@ -81,7 +81,6 @@
>  
>  
>  extern long arch_ptrace(struct task_struct *child, long request, long addr, long data);
> -extern int ptrace_traceme(void);
>  extern int ptrace_readdata(struct task_struct *tsk, unsigned long src, char __user *dst, int len);
>  extern int ptrace_writedata(struct task_struct *tsk, char __user *src, unsigned long dst, int len);
>  extern int ptrace_attach(struct task_struct *tsk);
> Index: linux-2.6/kernel/ptrace.c
> ===================================================================
> --- linux-2.6.orig/kernel/ptrace.c	2010-01-26 18:02:55.627012005 +0100
> +++ linux-2.6/kernel/ptrace.c	2010-01-26 18:04:22.163015407 +0100
> @@ -220,7 +220,7 @@ out:
>   * Performs checks and sets PT_PTRACED.
>   * Should be used by all ptrace implementations for PTRACE_TRACEME.
>   */
> -int ptrace_traceme(void)
> +static int ptrace_traceme(void)
>  {
>  	int ret = -EPERM;
>  
---end quoted text---

  parent reply	other threads:[~2010-04-28 11:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-01 19:18 [PATCH 1/2]: mark ptrace_traceme static Christoph Hellwig
2010-02-01 20:08 ` Roland McGrath
2010-04-28 11:45 ` Christoph Hellwig [this message]
2010-04-28 13:06   ` Oleg Nesterov
2010-04-28 19:19     ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100428114541.GA4705@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox