From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756511Ab0D1SiI (ORCPT ); Wed, 28 Apr 2010 14:38:08 -0400 Received: from kroah.org ([198.145.64.141]:38312 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756256Ab0D1Sgt (ORCPT ); Wed, 28 Apr 2010 14:36:49 -0400 Date: Wed, 28 Apr 2010 11:26:29 -0700 From: Greg KH To: Joe Perches Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Greg Kroah-Hartman Subject: Re: [PATCH 08/13] drivers/staging/rtl8192e: Hoist assign from if Message-ID: <20100428182629.GC8509@kroah.com> References: <424b1a80990a872003a7758ef066bbc956eb849e.1269493047.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <424b1a80990a872003a7758ef066bbc956eb849e.1269493047.git.joe@perches.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2010 at 10:17:02PM -0700, Joe Perches wrote: > --- a/drivers/staging/rtl8192e/ieee80211/ieee80211_softmac.c > +++ b/drivers/staging/rtl8192e/ieee80211/ieee80211_softmac.c > @@ -1933,7 +1933,8 @@ ieee80211_rx_auth_rq(struct ieee80211_device *ieee, struct sk_buff *skb) > //IEEE80211DMESG("Rx probe"); > ieee->softmac_stats.rx_auth_rq++; > > - if ((status = auth_rq_parse(skb, dest))!= -1){ > + status = auth_rq_parse(skb, dest); > + if (status!= -1) { Same problem...