From: Greg KH <greg@kroah.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 09/13] drivers/staging/rtl8192su: Hoist assign from if
Date: Wed, 28 Apr 2010 11:27:10 -0700 [thread overview]
Message-ID: <20100428182710.GD8509@kroah.com> (raw)
In-Reply-To: <c45ba099fc8f31f166c4067f2eff609c8eaf422f.1269493047.git.joe@perches.com>
On Wed, Mar 24, 2010 at 10:17:03PM -0700, Joe Perches wrote:
> --- a/drivers/staging/rtl8192su/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8192su/ieee80211/ieee80211_softmac.c
> @@ -1690,7 +1690,8 @@ ieee80211_rx_auth_rq(struct ieee80211_device *ieee, struct sk_buff *skb)
> //IEEE80211DMESG("Rx probe");
> ieee->softmac_stats.rx_auth_rq++;
>
> - if ((status = auth_rq_parse(skb, dest))!= -1){
> + status = auth_rq_parse(skb, dest);
> + if (status!= -1) {
And again. Did you do this with some tool and not by hand?
Did you not run your patch through checkpatch after creating it and
before sending it to me?
thanks,
greg k-h
next prev parent reply other threads:[~2010-04-28 18:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 5:16 [PATCH 00/13] drivers/staging: Hoist assigns from if Joe Perches
2010-03-25 5:16 ` [PATCH 01/13] drivers/staging/cx25821: Hoist assign " Joe Perches
2010-03-25 5:16 ` [PATCH 02/13] drivers/staging/dt3155: " Joe Perches
2010-04-28 18:20 ` Greg KH
2010-03-25 5:16 ` [PATCH 03/13] drivers/staging/otus/80211core: " Joe Perches
2010-03-25 5:16 ` [PATCH 04/13] drivers/staging/otus: " Joe Perches
2010-03-25 5:16 ` [PATCH 05/13] drivers/staging/rt2860: " Joe Perches
2010-03-25 5:17 ` [PATCH 06/13] drivers/staging/rt2870: " Joe Perches
2010-03-25 5:17 ` [PATCH 07/13] drivers/staging/rtl8187se: " Joe Perches
2010-04-28 18:24 ` Greg KH
2010-03-25 5:17 ` [PATCH 08/13] drivers/staging/rtl8192e: " Joe Perches
2010-04-28 18:26 ` Greg KH
2010-03-25 5:17 ` [PATCH 09/13] drivers/staging/rtl8192su: " Joe Perches
2010-04-28 18:27 ` Greg KH [this message]
2010-04-28 19:04 ` Joe Perches
2010-04-28 19:11 ` Greg KH
2010-04-28 19:20 ` Joe Perches
2010-04-28 19:41 ` Greg KH
2010-04-28 20:11 ` Joe Perches
2010-03-25 5:17 ` [PATCH 10/13] drivers/staging/rtl8192u: " Joe Perches
2010-04-28 18:27 ` Greg KH
2010-03-25 5:17 ` [PATCH 11/13] drivers/staging/vt6655: " Joe Perches
2010-04-28 18:28 ` Greg KH
2010-03-25 5:17 ` [PATCH 12/13] drivers/staging/vt6656: " Joe Perches
2010-04-28 18:29 ` Greg KH
2010-03-25 5:17 ` [PATCH 13/13] drivers/staging/wlags49_h2: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100428182710.GD8509@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox