From: Greg KH <gregkh@suse.de>
To: Joe Perches <joe@perches.com>
Cc: Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 09/13] drivers/staging/rtl8192su: Hoist assign from if
Date: Wed, 28 Apr 2010 12:41:00 -0700 [thread overview]
Message-ID: <20100428194100.GA3602@suse.de> (raw)
In-Reply-To: <1272482446.9188.4.camel@Joe-Laptop.home>
On Wed, Apr 28, 2010 at 12:20:46PM -0700, Joe Perches wrote:
> On Wed, 2010-04-28 at 12:11 -0700, Greg KH wrote:
> > On Wed, Apr 28, 2010 at 12:04:49PM -0700, Joe Perches wrote:
> > > On Wed, 2010-04-28 at 11:27 -0700, Greg KH wrote:
> > > > On Wed, Mar 24, 2010 at 10:17:03PM -0700, Joe Perches wrote:
> > > > > --- a/drivers/staging/rtl8192su/ieee80211/ieee80211_softmac.c
> > > > > +++ b/drivers/staging/rtl8192su/ieee80211/ieee80211_softmac.c
> > > > > @@ -1690,7 +1690,8 @@ ieee80211_rx_auth_rq(struct ieee80211_device *ieee, struct sk_buff *skb)
> > > > > //IEEE80211DMESG("Rx probe");
> > > > > ieee->softmac_stats.rx_auth_rq++;
> > > > >
> > > > > - if ((status = auth_rq_parse(skb, dest))!= -1){
> > > > > + status = auth_rq_parse(skb, dest);
> > > > > + if (status!= -1) {
> > > >
> > > > And again. Did you do this with some tool and not by hand?
> > > []
> > > > Did you not run your patch through checkpatch after creating it and
> > > > before sending it to me?
> > >
> > > >From the original 0/13 introduction:
> > > http://lkml.org/lkml/2010/3/25/6
> > >
> > > Used scripts/cvt_kernel.style.pl:
> > > --convert-hoist_assigns_from_if
> > > and verified visually.
> > >
> > > checkpatch errors ignored
> > >
> > > The script itself is:
> > > http://lkml.org/lkml/2010/3/24/447
> >
> > And this points out why I hate scripts.
> >
> > It is _trivial_ to fix up the obvious formatting problem, on the same
> > line that you are modifying, when doing so.
>
> Define _trivial_ and define obvious.
"I know it when I see it."
next prev parent reply other threads:[~2010-04-28 19:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 5:16 [PATCH 00/13] drivers/staging: Hoist assigns from if Joe Perches
2010-03-25 5:16 ` [PATCH 01/13] drivers/staging/cx25821: Hoist assign " Joe Perches
2010-03-25 5:16 ` [PATCH 02/13] drivers/staging/dt3155: " Joe Perches
2010-04-28 18:20 ` Greg KH
2010-03-25 5:16 ` [PATCH 03/13] drivers/staging/otus/80211core: " Joe Perches
2010-03-25 5:16 ` [PATCH 04/13] drivers/staging/otus: " Joe Perches
2010-03-25 5:16 ` [PATCH 05/13] drivers/staging/rt2860: " Joe Perches
2010-03-25 5:17 ` [PATCH 06/13] drivers/staging/rt2870: " Joe Perches
2010-03-25 5:17 ` [PATCH 07/13] drivers/staging/rtl8187se: " Joe Perches
2010-04-28 18:24 ` Greg KH
2010-03-25 5:17 ` [PATCH 08/13] drivers/staging/rtl8192e: " Joe Perches
2010-04-28 18:26 ` Greg KH
2010-03-25 5:17 ` [PATCH 09/13] drivers/staging/rtl8192su: " Joe Perches
2010-04-28 18:27 ` Greg KH
2010-04-28 19:04 ` Joe Perches
2010-04-28 19:11 ` Greg KH
2010-04-28 19:20 ` Joe Perches
2010-04-28 19:41 ` Greg KH [this message]
2010-04-28 20:11 ` Joe Perches
2010-03-25 5:17 ` [PATCH 10/13] drivers/staging/rtl8192u: " Joe Perches
2010-04-28 18:27 ` Greg KH
2010-03-25 5:17 ` [PATCH 11/13] drivers/staging/vt6655: " Joe Perches
2010-04-28 18:28 ` Greg KH
2010-03-25 5:17 ` [PATCH 12/13] drivers/staging/vt6656: " Joe Perches
2010-04-28 18:29 ` Greg KH
2010-03-25 5:17 ` [PATCH 13/13] drivers/staging/wlags49_h2: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100428194100.GA3602@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox