public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Lars Lindley <lindley@coyote.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>, greg KH <gregkh@suse.de>,
	Pavel Machek <pavel@ucw.cz>,
	devel@driverdev.osuosl.org,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: winbond: localpara.h whitespace and indentation fixes.
Date: Wed, 28 Apr 2010 15:50:10 -0700	[thread overview]
Message-ID: <20100428225010.GC24604@kroah.com> (raw)
In-Reply-To: <4BA2B0AB.4070607@coyote.org>

On Fri, Mar 19, 2010 at 12:00:59AM +0100, Lars Lindley wrote:
> On 2010-03-18 17:22, Pekka Enberg wrote:
> > Lars Lindley wrote:
> >> +/* refer Bitmap2RateValue table */
> >> +#define LOCAL_ALL_SUPPORTED_RATES_BITMAP    0x130c1a66 /*
> >> +                                * the bitmap value
> >> +                                * of all the H/W
> >> +                                * supported rates:
> >> +                                * 1, 2, 5.5, 11,
> >> +                                * 6, 9, 12, 18,
> >> +                                * 24, 36, 48, 54
> >> +                                */
> > 
> > The comments look funny. You might want to move them above the #defines.
> >
> >> +    u8    region;        /* real region setting of the device */
> >> +    u8    Reserved_1[2];
> >> +
> >> +/* power-save variables */
> > 
> > I think this wants to be moved one indentation level to the right.
> > 
> Ok here's a patch that applies over the old one to fix this..
> Hope it looks all right.. :)

Can you merge the two of them together and resend?

thanks,

greg k-h

  parent reply	other threads:[~2010-04-28 23:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16  8:21 [PATCH] staging: winbond: localpara.h whitespace and indentation fixes Lars Lindley
2010-03-18 16:22 ` Pekka Enberg
2010-03-18 23:00   ` Lars Lindley
2010-03-19  5:45     ` Pekka Enberg
2010-03-21  6:58     ` Pavel Machek
2010-04-28 22:50     ` Greg KH [this message]
2010-05-02  8:34       ` Lars Lindley
2010-05-03 18:45         ` Greg KH
2010-05-08 12:53           ` Lars Lindley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100428225010.GC24604@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=lindley@coyote.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox