From: Steffen Klassert <steffen.klassert@secunet.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Herbert Xu <herbert@gondor.hengli.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/8] padata: cpu hotplug code should depend on CONFIG_HOTPLUG_CPU
Date: Thu, 29 Apr 2010 14:40:10 +0200 [thread overview]
Message-ID: <20100429124010.GF5275@secunet.com> (raw)
In-Reply-To: <20100429123636.GD5275@secunet.com>
This patch makes the padata cpu hotplug code dependend on CONFIG_HOTPLUG_CPU.
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
---
kernel/padata.c | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/kernel/padata.c b/kernel/padata.c
index 5b44d0f..1209a17 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -570,6 +570,7 @@ void padata_stop(struct padata_instance *pinst)
}
EXPORT_SYMBOL(padata_stop);
+#ifdef CONFIG_HOTPLUG_CPU
static int padata_cpu_callback(struct notifier_block *nfb,
unsigned long action, void *hcpu)
{
@@ -621,6 +622,7 @@ static int padata_cpu_callback(struct notifier_block *nfb,
return NOTIFY_OK;
}
+#endif
/*
* padata_alloc - allocate and initialize a padata instance
@@ -631,7 +633,6 @@ static int padata_cpu_callback(struct notifier_block *nfb,
struct padata_instance *padata_alloc(const struct cpumask *cpumask,
struct workqueue_struct *wq)
{
- int err;
struct padata_instance *pinst;
struct parallel_data *pd;
@@ -654,18 +655,16 @@ struct padata_instance *padata_alloc(const struct cpumask *cpumask,
pinst->flags = 0;
+#ifdef CONFIG_HOTPLUG_CPU
pinst->cpu_notifier.notifier_call = padata_cpu_callback;
pinst->cpu_notifier.priority = 0;
- err = register_hotcpu_notifier(&pinst->cpu_notifier);
- if (err)
- goto err_free_cpumask;
+ register_hotcpu_notifier(&pinst->cpu_notifier);
+#endif
mutex_init(&pinst->lock);
return pinst;
-err_free_cpumask:
- free_cpumask_var(pinst->cpumask);
err_free_pd:
padata_free_pd(pd);
err_free_inst:
@@ -689,7 +688,9 @@ void padata_free(struct padata_instance *pinst)
while (atomic_read(&pinst->pd->refcnt) != 0)
yield();
+#ifdef CONFIG_HOTPLUG_CPU
unregister_hotcpu_notifier(&pinst->cpu_notifier);
+#endif
padata_free_pd(pinst->pd);
free_cpumask_var(pinst->cpumask);
kfree(pinst);
--
1.5.6.5
next prev parent reply other threads:[~2010-04-30 18:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 12:36 [PATCH 0/8] padata: fixes/cleanups Steffen Klassert
2010-04-29 12:37 ` [PATCH 1/8] padata: Dont scale the parallel objects with the cpus Steffen Klassert
2010-04-29 12:40 ` Steffen Klassert [this message]
2010-04-29 12:40 ` [PATCH 3/8] padata: Remove superfluous might_sleep Steffen Klassert
2010-04-29 12:41 ` [PATCH 4/8] padata: Initialize the padata queues only for the used cpus Steffen Klassert
2010-04-29 12:42 ` [PATCH 5/8] padata: Use get_online_cpus/put_online_cpus Steffen Klassert
2010-04-29 12:43 ` [PATCH 6/8] padata: Use a timer to handle the reorder queues Steffen Klassert
2010-04-29 23:06 ` Andrew Morton
2010-04-30 11:20 ` Steffen Klassert
2010-05-03 3:38 ` Herbert Xu
2010-04-29 12:44 ` [PATCH 7/8] padata: Flush the padata queues actively Steffen Klassert
2010-04-29 23:11 ` Andrew Morton
2010-04-30 11:24 ` Steffen Klassert
2010-04-29 12:45 ` [PATCH 8/8] padata: Add some code comments Steffen Klassert
2010-04-29 23:13 ` [PATCH 0/8] padata: fixes/cleanups Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100429124010.GF5275@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=akpm@linux-foundation.org \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox