Re: [RFC PATCH 1/4] Mobile security processor driver

[Greg KH <greg@kroah.com>]

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Apr 29, 2010 at 01:48:25PM -0700, Epshteyn, Eugene wrote:
> Hi Greg,
> 
> Mark asked me to post the patches for him.

Then say that :)

And why would Mark need someone else to do that?

> These patches are on 2.6.34 with the 0415 next patch.

Then say that :)

> We were hoping to get more comments from people to add to TODO list,
> so that the vendor can plan their work to fix the issues and make the
> driver more acceptable to the community.

Isn't Intel the "vendor" here?  If not, why not have them directly
interact with us, you do not want to be put into the middle, it only
slows things down for everyone and is not how Linux kernel development
works.

> The driver already went through some clean-up, but much more work is
> still needed.

Yes, that TODO list is quite large already, fix up all of those and then
ask for more review please.  Reviewing code you know needs lots of work
isn't all that nice to do.

So again, please fix all of that first, get those changes accepted, and
then we can talk :)

thanks,

greg k-h