Re: linux-next: build warning after merge of the driver-core.current tree

Greg KH
2010-04-30T17:34:28Z

On Fri, Apr 30, 2010 at 09:35:34AM +1000, Stephen Rothwell wrote:
> Hi Grant,
>
> After merging the driver-core.current tree, today's linux-next build
> (x86_64 allmodconfig) produced this warning:
>
> drivers/base/firmware_class.c: In function 'release_firmware':
> drivers/base/firmware_class.c:597: warning: passing argument 1 of 'firmware_free_data' discards qualifiers from pointer target type
> drivers/base/firmware_class.c:133: note: expected 'struct firmware *' but argument is of type 'const struct firmware *'
>
> Introduced by commit 6454d23dedf4019fcae868818ae63c755dd42be0
> ("firmware_class: fix memory leak - free allocated pages").

Thanks, I've fixed this up, the release call should not have 'const'
on it as it is going to touch the pointer passed to it :)

thanks,

greg k-h