From: Kristoffer Ericson <kristoffer.ericson@gmail.com>
To: Komuro <komurojun-mbn@nifty.com>
Cc: linux-pcmcia@lists.infradead.org, linux@dominikbrodowski.net,
jeff@garzik.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG: invalid hash] - update pata_pcmcia/ide-cs with transcend and kingston cards
Date: Sun, 2 May 2010 18:37:11 +0200 [thread overview]
Message-ID: <20100502163711.GA1362@boggieman> (raw)
In-Reply-To: <9179202.147991272799869586.komurojun-mbn@nifty.com>
On Sun, May 02, 2010 at 08:31:09PM +0900, Komuro wrote:
> Hi,
>
> The hash of "CF CARD 1GB" and "TS4GCF133" are wrong.
>
> pcmcia: pata_pcmcia: invalid hash for product string "CF CARD 1GB": is 0x3e520
> e17, should be 0x55d5bffb
> pcmcia: see Documentation/pcmcia/devicetable.txt for details
> pcmcia: pata_pcmcia: invalid hash for product string "TS4GCF133": is 0x9351e59
> d, should be 0x7558f133
> pcmcia: see Documentation/pcmcia/devicetable.txt for details
>
Ah, must have used the wrong hash settings on my converter for
those. Will post fixup patch shortly. Thanks!
Kristoffer
> >
> >On 04/19/2010 01:54 PM, Kristoffer Ericson wrote:
> >> This patch adds idstrings for Kingston 1GB/4GB and Transcend 4GB/8GB.
> >>
> >> Signed-off-by: Kristoffer Ericson<kristoffer.ericson@gmail.com>
> >>
> >> diff --git a/drivers/ide/ide-cs.c b/drivers/ide/ide-cs.c
> >> index ab87e4f..defce28 100644
> >> --- a/drivers/ide/ide-cs.c
> >> +++ b/drivers/ide/ide-cs.c
> >> @@ -409,6 +409,8 @@ static struct pcmcia_device_id ide_ids[] = {
> >> PCMCIA_DEVICE_PROD_ID12("Hyperstone", "Model1", 0x3d5b9ef5, 0xca6ab420),
> >> PCMCIA_DEVICE_PROD_ID12("IBM", "microdrive", 0xb569a6e5, 0xa6d76178),
> >> PCMCIA_DEVICE_PROD_ID12("IBM", "IBM17JSSFP20", 0xb569a6e5, 0xf2508753),
> >> + PCMCIA_DEVICE_PROD_ID12("KINGSTON", "CF CARD 1GB", 0x2e6d1829, 0x3e520e17
> ),
> >> + PCMCIA_DEVICE_PROD_ID12("KINGSTON", "CF CARD 4GB", 0x2e6d1829, 0x531e7d10
> ),
> >> PCMCIA_DEVICE_PROD_ID12("KINGSTON", "CF8GB", 0x2e6d1829, 0xacbe682e),
> >> PCMCIA_DEVICE_PROD_ID12("IO DATA", "CBIDE2 ", 0x547e66dc, 0x8671043
> b),
> >> PCMCIA_DEVICE_PROD_ID12("IO DATA", "PCIDE", 0x547e66dc, 0x5c5ab149),
> >> @@ -429,6 +431,8 @@ static struct pcmcia_device_id ide_ids[] = {
> >> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80", 0x709b1bf1, 0x2a54d4b1)
> ,
> >> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1, 0x969aa4f2
> ),
> >> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120", 0x709b1bf1, 0xf54a91c8
> ),
> >> + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF133", 0x709b1bf1, 0x9351e59d)
> ,
> >> + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS8GCF133", 0x709b1bf1, 0xb2f89b47)
> ,
> >> PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994, 0x3e232852),
> >> PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c, 0x212bb918),
> >> PCMCIA_DEVICE_PROD_ID1("STI Flash", 0xe4a13209),
> >> diff --git a/drivers/ata/pata_pcmcia.c b/drivers/ata/pata_pcmcia.c
> >> index 3c3172d..4164dd2 100644
> >> --- a/drivers/ata/pata_pcmcia.c
> >> +++ b/drivers/ata/pata_pcmcia.c
> >> @@ -424,6 +424,8 @@ static struct pcmcia_device_id pcmcia_devices[] = {
> >> PCMCIA_DEVICE_PROD_ID12("Hyperstone", "Model1", 0x3d5b9ef5, 0xca6ab420),
> >> PCMCIA_DEVICE_PROD_ID12("IBM", "microdrive", 0xb569a6e5, 0xa6d76178),
> >> PCMCIA_DEVICE_PROD_ID12("IBM", "IBM17JSSFP20", 0xb569a6e5, 0xf2508753),
> >> + PCMCIA_DEVICE_PROD_ID12("KINGSTON", "CF CARD 1GB", 0x2e6d1829, 0x3e520e17
> ),
> >> + PCMCIA_DEVICE_PROD_ID12("KINGSTON", "CF CARD 4GB", 0x2e6d1829, 0x531e7d10
> ),
> >> PCMCIA_DEVICE_PROD_ID12("KINGSTON", "CF8GB", 0x2e6d1829, 0xacbe682e),
> >> PCMCIA_DEVICE_PROD_ID12("IO DATA", "CBIDE2 ", 0x547e66dc, 0x8671043
> b),
> >> PCMCIA_DEVICE_PROD_ID12("IO DATA", "PCIDE", 0x547e66dc, 0x5c5ab149),
> >> @@ -444,6 +446,8 @@ static struct pcmcia_device_id pcmcia_devices[] = {
> >> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80", 0x709b1bf1, 0x2a54d4b1)
> ,
> >> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1, 0x969aa4f2
> ),
> >> PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120", 0x709b1bf1, 0xf54a91c8
> ),
> >> + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF133", 0x709b1bf1, 0x9351e59d)
> ,
> >> + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS8GCF133", 0x709b1bf1, 0xb2f89b47)
> ,
> >> PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994, 0x3e232852),
> >> PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c, 0x212bb918),
> >> PCMCIA_DEVICE_PROD_ID1("STI Flash", 0xe4a13209),
> >>
>
> Best Regards
> Komuro
prev parent reply other threads:[~2010-05-02 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 17:54 PATCH - update pata_pcmcia/ide-cs with transcend and kingston cards Kristoffer Ericson
2010-04-23 1:52 ` Jeff Garzik
2010-05-02 11:31 ` [BUG: invalid hash] " Komuro
2010-05-02 16:37 ` Kristoffer Ericson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100502163711.GA1362@boggieman \
--to=kristoffer.ericson@gmail.com \
--cc=jeff@garzik.org \
--cc=komurojun-mbn@nifty.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox