From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Mike Rapoport <mike.rapoport@gmail.com>
Cc: Mike Rapoport <mike@compulab.co.il>,
Ryan Mallon <ryan@bluewatersys.com>,
linux-kernel@vger.kernel.org,
Yulia Vilensky <vilensky@compulab.co.il>
Subject: Re: [PATCH v3] ds2782_battery: add support for ds2786 battery gas gauge
Date: Mon, 3 May 2010 00:12:20 +0400 [thread overview]
Message-ID: <20100502201220.GA26113@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <p2qf870da181004261239r42aef5b1h2ae416712b465e2d@mail.gmail.com>
On Mon, Apr 26, 2010 at 10:39:41PM +0300, Mike Rapoport wrote:
> On Mon, Apr 26, 2010 at 9:22 PM, Anton Vorontsov <cbouatmailru@gmail.com> wrote:
> >
> > Btw, I don't quite like the 'if (id->driver_data == 1)' stuff.
> > How about the following patch on top?
> >
> > From acf917d3880465b76875f671ee450a8fdff62c9f Mon Sep 17 00:00:00 2001
> > From: Anton Vorontsov <cbouatmailru@gmail.com>
> > Date: Mon, 26 Apr 2010 22:10:52 +0400
> > Subject: [PATCH] ds2782_battery: Get rid of magic numbers in driver_data
> >
> > Constructions like 'if (id->driver_data == 1)' look quite weird.
> > This patch introduces 'enum ds278x_num_id', which makes things
> > much more understandable, i.e. 'if (id->driver_data == DS2786)'.
>
> agree
>
> > Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
>
> Acked-by: Mike Rapoport <mike@compulab.co.il>
Thanks! Applied.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
prev parent reply other threads:[~2010-05-02 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 11:05 [PATCH v3] ds2782_battery: add support for ds2786 battery gas gauge Mike Rapoport
2010-04-26 18:22 ` Anton Vorontsov
2010-04-26 19:39 ` Mike Rapoport
2010-05-02 20:12 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100502201220.GA26113@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.rapoport@gmail.com \
--cc=mike@compulab.co.il \
--cc=ryan@bluewatersys.com \
--cc=vilensky@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox