From: Greg KH <gregkh@suse.de>
To: Yinghai <yinghai.lu@oracle.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
trenn@suse.de, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6.31.13] Build failure at arch/x86/kernel/apic/io_apic.c
Date: Mon, 3 May 2010 10:58:52 -0700 [thread overview]
Message-ID: <20100503175852.GB3490@suse.de> (raw)
In-Reply-To: <4BDF0CF1.5070006@oracle.com>
On Mon, May 03, 2010 at 10:50:41AM -0700, Yinghai wrote:
> On 05/03/2010 10:44 AM, Greg KH wrote:
> > On Mon, May 03, 2010 at 10:16:06AM -0700, Yinghai wrote:
> >> On 05/01/2010 11:07 AM, Greg KH wrote:
> >>> On Mon, Apr 12, 2010 at 01:10:59PM +0900, Tetsuo Handa wrote:
> >>>> Commit d539e5576605d048e6aeb21cbe3a8e71dc5eea81 "x86: Fix SCI on IOAPIC != 0"
> >>>> introduced "void setup_IO_APIC_irq_extra(u32 gsi)" which calls
> >>>> mp_find_ioapic() and mp_find_ioapic_pin().
> >>>>
> >>>> This commit does not compile if CONFIG_X86_IO_APIC=y and CONFIG_ACPI=n .
> >>>
> >>> Why would you want to build without ACPI on any modern system? Anyway,
> >>> have a fix for this?
> >>>
> >> maybe just put #ifdef CONFIG_ACPI around the callee etc?
> >
> > Ick. How was it solved upstream?
> >
>
> those two functions are moved to arch/x86/kernel/apic/io_apic.c
>
> maybe you can put that patch to 2.6.31.xx?
Ah, yeah, that might be good, I'll see about that, if I do another
.31-stable release, which right now, I do not think so.
thanks,
greg k-h
next prev parent reply other threads:[~2010-05-03 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201004120230.o3C2UhfQ050532@www262.sakura.ne.jp>
[not found] ` <20100412024446.GA28141@suse.de>
2010-04-12 4:10 ` [2.6.31.13] Build failure at arch/x86/kernel/apic/io_apic.c Tetsuo Handa
2010-05-01 18:07 ` Greg KH
2010-05-03 17:16 ` Yinghai
2010-05-03 17:44 ` Greg KH
2010-05-03 17:50 ` Yinghai
2010-05-03 17:58 ` Greg KH [this message]
2010-05-06 22:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100503175852.GB3490@suse.de \
--to=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=trenn@suse.de \
--cc=yinghai.lu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox