public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Lars Lindley <lindley@coyote.org>
Cc: gregkh@suse.de, penberg@cs.helsinki.fi, pavel@ucw.cz,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: wb35tx.c Coding style fixes.
Date: Mon, 3 May 2010 11:48:32 -0700	[thread overview]
Message-ID: <20100503184832.GA10862@kroah.com> (raw)
In-Reply-To: <4BDD3C4F.7030500@coyote.org>

On Sun, May 02, 2010 at 10:48:15AM +0200, Lars Lindley wrote:
> On 2010-04-29 18:06, Greg KH wrote:
> > On Sun, Mar 28, 2010 at 10:25:25AM +0200, Lars Lindley wrote:
> >> I fixed the problems reported by checkpatch.pl except some long
> >> lines and printk:s.
> >> I also removed versioning comments.
> >> Builds fine, .o identical to before and checked it with
> >> Dan Carpenters strip_whitespace.pl and diff.
> >>
> >> Signed-off-by: Lars Lindley <lindley@coyote.org>
> > 
> > This no longer applies on linux-next due to some upstream changes.  Can
> > you rediff it and resend it?
> > 
> > thanks,
> > 
> > greg k-h
> > 
> 
> Ok, does this work better?

Close, but it still fails on the first chunk:
	patching file drivers/staging/winbond/wb35tx.c
	Hunk #1 FAILED at 1.
	Hunk #2 succeeded at 26 (offset 1 line).
	Hunk #3 succeeded at 65 (offset 1 line).
	Hunk #4 succeeded at 114 (offset 1 line).
	Hunk #5 succeeded at 125 (offset 1 line).
	Hunk #6 succeeded at 134 (offset 1 line).
	Hunk #7 succeeded at 201 (offset 1 line).
	Hunk #8 succeeded at 252 (offset 1 line).
	Hunk #9 succeeded at 264 (offset 1 line).
	Hunk #10 succeeded at 288 (offset 1 line).
	1 out of 10 hunks FAILED -- saving rejects to file drivers/staging/winbond/wb35tx.c.rej

Care to redo it on top of the linux-next tree?

thanks,

greg k-h

      reply	other threads:[~2010-05-03 19:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-28  8:25 [PATCH] staging: winbond: wb35tx.c Coding style fixes Lars Lindley
2010-03-28 12:02 ` Pavel Machek
2010-04-29 16:06 ` Greg KH
2010-05-02  8:48   ` Lars Lindley
2010-05-03 18:48     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100503184832.GA10862@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=lindley@coyote.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox