From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH -next] power: fix block_io.c printk warning
Date: Tue, 4 May 2010 00:00:56 +0200 [thread overview]
Message-ID: <201005040000.56650.rjw@sisk.pl> (raw)
In-Reply-To: <20100503100611.2ca63b58.randy.dunlap@oracle.com>
On Monday 03 May 2010, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix printk format warning in block_io.c:
>
> kernel/power/block_io.c:41: warning: format '%ld' expects type 'long int', but argument 2 has type 'sector_t'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Applied to suspend-2.6/linux-next.
Thanks,
Rafael
> ---
> kernel/power/block_io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20100503.orig/kernel/power/block_io.c
> +++ linux-next-20100503/kernel/power/block_io.c
> @@ -37,8 +37,8 @@ static int submit(int rw, struct block_d
> bio->bi_end_io = end_swap_bio_read;
>
> if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE) {
> - printk(KERN_ERR "PM: Adding page to bio failed at %ld\n",
> - sector);
> + printk(KERN_ERR "PM: Adding page to bio failed at %llu\n",
> + (unsigned long long)sector);
> bio_put(bio);
> return -EFAULT;
> }
>
>
next prev parent reply other threads:[~2010-05-03 22:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 5:16 linux-next: Tree for May 3 Stephen Rothwell
2010-05-03 17:06 ` [PATCH -next] power: fix block_io.c printk warning Randy Dunlap
2010-05-03 22:00 ` Rafael J. Wysocki [this message]
2010-05-03 17:07 ` [PATCH -next] usbserial: fix mos7720 dependencies Randy Dunlap
2010-05-03 17:09 ` [PATCH -next] staging: fix cxt1e1 module names Randy Dunlap
2010-05-03 18:02 ` Joe Perches
2010-05-03 18:06 ` Randy Dunlap
2010-05-03 19:33 ` [PATCH -next] staging/cxt1e1: Convert bare printks to pr_<level> Joe Perches
2010-05-05 12:21 ` Peter Hüwe
2010-05-05 16:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005040000.56650.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).