Re: [PATCH] hwmon: applesmc: Add temperature sensor labels to sysfs interface

Jean Delvare
2010-05-04T11:38:47Z

On Tue, 04 May 2010 13:15:51 +0200, Henrik Rydberg wrote:
> Jean Delvare wrote:
> [...]
> >> @@ -1578,6 +1717,8 @@ static int __init applesmc_init(void)
> >> }
> >> ret = sysfs_create_file(&pdev->dev.kobj,
> >> temperature_attributes[i]);
> >
> > Missing error handling.
> >
> >> + ret = sysfs_create_file(&pdev->dev.kobj,
> >> + label_attributes[i]);
> >> if (ret)
> >> goto out_temperature;
> >> }
> >
>
> Shoot, my bad review. Will send a new patch. While at it, the same function
> seems to leak fan attribute groups. Want me to correct such issues (in another
> patch)?

Yes please. As a bugfix, that would even be a candidate for 2.6.34. I
have another patch (for asc7621) pending already.

--
Jean Delvare