From: "Serge E. Hallyn" <serue@us.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Ashwin Ganti <ashwin.ganti@gmail.com>, Greg KH <greg@kroah.com>,
rsc@swtch.com, ericvh@gmail.com,
linux-security-module@vger.kernel.org,
Ron Minnich <rminnich@gmail.com>,
jt.beard@gmail.com, Andrew Morgan <morgan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>, Eric Paris <eparis@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Randy Dunlap <rdunlap@xenotime.net>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Kyle Moffett <kyle@moffetthome.net>,
Steve Grubb <sgrubb@redhat.com>
Subject: Re: [PATCH 3/3] RFC: p9auth: add p9auth fs
Date: Tue, 4 May 2010 10:14:43 -0500 [thread overview]
Message-ID: <20100504151443.GA18700@us.ibm.com> (raw)
In-Reply-To: <4067.1272985037@redhat.com>
Quoting David Howells (dhowells@redhat.com):
> Serge E. Hallyn <serue@us.ibm.com> wrote:
>
> > + result = kzalloc(MAX_DIGEST_SIZE, GFP_KERNEL);
> > ...
> > + ret = crypto_hash_digest(&desc, &sg, plain_text_size, result);
>
> Does result have to be pre-cleared?
>
> > + user_buf = kzalloc(count+1, GFP_KERNEL);
> > + if (!user_buf)
> > + goto out;
> > +
> > + if (copy_from_user(user_buf, buffer, count)) {
>
> user_buf doesn't need preclearing. It's just a waste of time. This occurs
> three times.
Hm, yeah, the first doesn't need it at all, and the latter two
should just kmalloc and set user_buf[count] = '\0'.
thanks,
-serge
prev parent reply other threads:[~2010-05-04 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 16:41 [PATCH 0/3] p9auth fs: introduction Serge E. Hallyn
2010-04-27 16:42 ` [PATCH 1/3] p9auth: split core function out of some set*{u,g}id functions Serge E. Hallyn
2010-05-04 14:52 ` David Howells
2010-04-27 16:43 ` [PATCH 2/3] p9auth: add CAP_GRANT_ID to authorize use of /dev/caphash Serge E. Hallyn
2010-04-27 16:45 ` [PATCH 3/3] RFC: p9auth: add p9auth fs Serge E. Hallyn
2010-04-28 11:17 ` Oleg Nesterov
2010-04-28 15:10 ` Serge E. Hallyn
2010-04-28 15:39 ` Oleg Nesterov
2010-05-03 23:50 ` Serge E. Hallyn
2010-05-04 14:57 ` David Howells
2010-05-04 15:14 ` Serge E. Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504151443.GA18700@us.ibm.com \
--to=serue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ashwin.ganti@gmail.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=ericvh@gmail.com \
--cc=greg@kroah.com \
--cc=jt.beard@gmail.com \
--cc=kyle@moffetthome.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=morgan@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=oleg@redhat.com \
--cc=rdunlap@xenotime.net \
--cc=rminnich@gmail.com \
--cc=rsc@swtch.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox