From: Alan Cox <alan@linux.intel.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Staging: RAR support - bring ready to move from staging
Date: Tue, 4 May 2010 17:27:04 +0100 [thread overview]
Message-ID: <20100504172704.77cdbeb8@linux.intel.com> (raw)
In-Reply-To: <20100504155112.GA26143@kroah.com>
On Tue, 4 May 2010 08:51:12 -0700
Greg KH <greg@kroah.com> wrote:
> On Tue, May 04, 2010 at 10:50:32AM +0100, Alan Cox wrote:
> >
> > rar: perform a clean up pass
> >
> > - Move to a registration model where each RAR is claimed/unclaimed
> > - Use that to fix the client stuff (one client per RAR so no need
> > to queue stuff)
> > - Support unregister so drivers can rmmod themselves safely
> > - Fix locking hang on calling rar lock from rar callback
> > - Clean up
> > - Kerneldoc
>
> I get the following build errors with this patch:
> CC [M] drivers/staging/memrar/memrar_handler.o
> drivers/staging/memrar/memrar_handler.c: In function
> ‘memrar_init’: drivers/staging/memrar/memrar_handler.c:910: warning:
> passing argument 1 of ‘register_rar’ makes integer from pointer
> without a cast
Expected - its a staging driver so I thought a patch that broke the API
of another staging driver was fine (the second patch will fix it up)
next prev parent reply other threads:[~2010-05-04 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 9:50 PATCH: RAR support - bring ready to move from staging Alan Cox
2010-05-04 15:51 ` Staging: " Greg KH
2010-05-04 16:27 ` Alan Cox [this message]
2010-05-04 17:20 ` Greg KH
2010-05-04 17:30 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504172704.77cdbeb8@linux.intel.com \
--to=alan@linux.intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox