From: Arnd Bergmann <arnd@arndb.de>
To: Alan Cox <alan@linux.intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@suse.de>
Subject: Re: possible locking bug in tty_open
Date: Tue, 4 May 2010 22:26:25 +0200 [thread overview]
Message-ID: <201005042226.26030.arnd@arndb.de> (raw)
In-Reply-To: <20100504204236.5dc6a34e@linux.intel.com>
On Tuesday 04 May 2010 21:42:36 Alan Cox wrote:
> On Sun, 2 May 2010 22:47:33 +0200
> Arnd Bergmann <arnd@arndb.de> wrote:
> > After the "retry_open:" label, we first get the tty_mutex
> > and then the BKL. However a the end of tty_open, we jump
> > back to retry_open with the BKL still held. If we run into
> > this case, the tty_open function will be left with the BKL
> > still held.
> I think all we need is probably this
>
> tty: Fix unbalanced BKL handling in error path
>
> Arnd noted:
>
> After the "retry_open:" label, we first get the tty_mutex
> and then the BKL. However a the end of tty_open, we jump
> back to retry_open with the BKL still held. If we run into
> this case, the tty_open function will be left with the BKL
> still held.
Yes, looks good.
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2010-05-04 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-02 20:47 possible locking bug in tty_open Arnd Bergmann
2010-05-04 9:43 ` Alan Cox
2010-05-04 19:42 ` Alan Cox
2010-05-04 20:26 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005042226.26030.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox