Re: [RFC PATCHSET] sched,perf: unify tracers in sched and move perf on top of TP

Peter Zijlstra
2010-05-04T17:29:31Z

On Tue, 2010-05-04 at 14:38 +0200, Tejun Heo wrote:
>
> This patchset does the following two things.
>
> * 0001-0007: Unify the three tracers (tracepoints, perf_events and
> preempt/sched notifiers) in scheduler.

Right, so I really don't like the SCHED_EVENT() thing much, esp the 3
different function postfixes.

> * 0008-0012: Move perf hooks in sched on top of tracepoints if TPs are
> enabled.

This seems to add a terrible amount of overhead for no particular
reason.

I know Ingo was pushing to consolidate things, but imho this cure is
worse than the ailment.