* [PATCH] Staging: Check kmalloc return value before use the buffer in ieee80211_softmac.c
@ 2010-05-05 6:56 wzt.wzt
2010-05-05 16:18 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: wzt.wzt @ 2010-05-05 6:56 UTC (permalink / raw)
To: linux-kernel; +Cc: devel, gregkh
Check kmalloc return value before use the buffer.
Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com>
---
.../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index 27d9257..8718ac9 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -1579,6 +1579,8 @@ static inline u16 auth_parse(struct sk_buff *skb, u8** challenge, int *chlen)
if(*(t++) == MFIE_TYPE_CHALLENGE){
*chlen = *(t++);
*challenge = (u8*)kmalloc(*chlen, GFP_ATOMIC);
+ if (!*challenge)
+ return -ENOMEM;
memcpy(*challenge, t, *chlen);
}
}
--
1.6.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Staging: Check kmalloc return value before use the buffer in ieee80211_softmac.c
2010-05-05 6:56 [PATCH] Staging: Check kmalloc return value before use the buffer in ieee80211_softmac.c wzt.wzt
@ 2010-05-05 16:18 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2010-05-05 16:18 UTC (permalink / raw)
To: wzt.wzt; +Cc: linux-kernel, devel, gregkh
On Wed, May 05, 2010 at 02:56:52PM +0800, wzt.wzt@gmail.com wrote:
> Check kmalloc return value before use the buffer.
>
> Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com>
>
> ---
> .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> index 27d9257..8718ac9 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> @@ -1579,6 +1579,8 @@ static inline u16 auth_parse(struct sk_buff *skb, u8** challenge, int *chlen)
> if(*(t++) == MFIE_TYPE_CHALLENGE){
> *chlen = *(t++);
> *challenge = (u8*)kmalloc(*chlen, GFP_ATOMIC);
> + if (!*challenge)
> + return -ENOMEM;
Great catch!
thanks for the patch, now queued up.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-05 16:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-05 6:56 [PATCH] Staging: Check kmalloc return value before use the buffer in ieee80211_softmac.c wzt.wzt
2010-05-05 16:18 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox