From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH -tip] x86,perf: P4 PMU -- protect sensible procedures from preemption
Date: Wed, 5 May 2010 21:42:34 +0400 [thread overview]
Message-ID: <20100505174234.GH5686@lenovo> (raw)
In-Reply-To: <20100505165731.GA6320@nowhere>
On Wed, May 05, 2010 at 06:57:34PM +0200, Frederic Weisbecker wrote:
...
> > @@ -741,7 +743,7 @@ static int p4_pmu_schedule_events(struct
> > {
> > unsigned long used_mask[BITS_TO_LONGS(X86_PMC_IDX_MAX)];
> > unsigned long escr_mask[BITS_TO_LONGS(ARCH_P4_TOTAL_ESCR)];
> > - int cpu = raw_smp_processor_id();
> > + int cpu = get_cpu();
> > struct hw_perf_event *hwc;
> > struct p4_event_bind *bind;
> > unsigned int i, thread, num;
> > @@ -777,6 +779,7 @@ reserve:
> > }
> >
> > done:
> > + put_cpu();
> > return num ? -ENOSPC : 0;
> > }
>
> That's no big deal. But I think the schedule_events() is called on
> pmu::enable() time, when preemption is already disabled.
>
We'll be on a safe side using get/put_cpu here (ie in case
if something get changed one day).
-- Cyrill
next prev parent reply other threads:[~2010-05-05 17:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 15:07 [PATCH -tip] x86,perf: P4 PMU -- protect sensible procedures from preemption Cyrill Gorcunov
2010-05-05 16:57 ` Frederic Weisbecker
2010-05-05 17:42 ` Cyrill Gorcunov [this message]
2010-05-05 17:58 ` Frederic Weisbecker
2010-05-06 6:44 ` Ingo Molnar
2010-05-06 7:39 ` Cyrill Gorcunov
2010-05-06 7:42 ` Ingo Molnar
2010-05-06 7:45 ` Cyrill Gorcunov
2010-05-06 13:45 ` Steven Rostedt
2010-05-06 14:48 ` Cyrill Gorcunov
2010-05-06 15:26 ` Cyrill Gorcunov
2010-05-06 18:32 ` Steven Rostedt
2010-05-06 18:36 ` Cyrill Gorcunov
-- strict thread matches above, loose matches on Subject: below --
2010-05-07 15:05 Cyrill Gorcunov
2010-05-08 8:06 ` Ingo Molnar
2010-05-08 8:09 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100505174234.GH5686@lenovo \
--to=gorcunov@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox