Re: [PATCHv4.1 5/8] USB: g_ffs: the FunctionFS gadget driver

[Greg KH <greg@kroah.com>]

On Wed, May 05, 2010 at 02:25:55PM +0200, Michal Nazarewicz wrote:
> The Function Filesystem (FunctioFS) lets one create USB
> composite functions in user space in the same way as GadgetFS
> lets one create USB gadgets in user space.  This allows
> creation of composite gadgets such that some of the functions
> are implemented in kernel space (for instance Ethernet, serial
> or mass storage) and other are implemented in user space.
> 
> Signed-off-by: Michal Nazarewicz <m.nazarewicz@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> There was a trivial bug in my previous patch.  The delta is:
> 
> diff --git a/drivers/usb/gadget/g_ffs.c b/drivers/usb/gadget/g_ffs.c
> index bed3641..4b0e4a0 100644
> --- a/drivers/usb/gadget/g_ffs.c
> +++ b/drivers/usb/gadget/g_ffs.c
> @@ -369,9 +369,8 @@ static int gfs_unbind(struct usb_composite_dev *cdev)
>  
>  
>  static int __gfs_do_config(struct usb_configuration *c,
> -			   int (*eth)(struct usb_configuration *c,
> -				      u8 ethaddr[ETH_ALEN]),
> -			   u8 ethaddr[ETH_ALEN])
> +			   int (*eth)(struct usb_configuration *c, u8 *ethaddr),
> +			   u8 *ethaddr)
>  {
>  	int ret;
> 
> ETH_ALEN is not defined if g_ffs is configured not to include ECM nor RNDIS.
> 
> Sorry about the confusion.

No problem, I merged it with the previous patch.

thanks,

greg k-h