public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Zachary Richey <zr.public@gmail.com>
Cc: gregkh@suse.de, fmhess@users.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix coding style issues in comedi_fops.c This patch fixes coding style issues reported by scripts/checkpatch.pl Signed-off-by: Zachary Richey <zr.public@gmail.com>
Date: Wed, 5 May 2010 23:22:32 -0700	[thread overview]
Message-ID: <20100506062232.GA23101@kroah.com> (raw)
In-Reply-To: <1273113587-2809-1-git-send-email-zr.public@gmail.com>

On Wed, May 05, 2010 at 10:39:47PM -0400, Zachary Richey wrote:
> ---
>  drivers/staging/comedi/comedi_fops.c |   56 +++++++++++++++++-----------------
>  1 files changed, 28 insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index aca9674..999cbb6 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -598,20 +598,20 @@ copyback:
>  static int parse_insn(struct comedi_device *dev, struct comedi_insn *insn,
>  		      unsigned int *data, void *file);
>  /*
> - * 	COMEDI_INSNLIST
> - * 	synchronous instructions
> - *
> - * 	arg:
> - * 		pointer to sync cmd structure
> - *
> - * 	reads:
> - * 		sync cmd struct at arg
> - * 		instruction list
> - * 		data (for writes)
> - *
> - * 	writes:
> - * 		data (for reads)
> - */
> +*	COMEDI_INSNLIST
> +*	synchronous instructions
> +*
> +*	arg:
> +*		pointer to sync cmd structure
> +*
> +*	reads:
> +*		sync cmd struct at arg
> +*		instruction list
> +*		data (for writes)
> +*
> +*	writes:
> +*		data (for reads)
> +*/
>  /* arbitrary limits */
>  #define MAX_SAMPLES 256
>  static int do_insnlist_ioctl(struct comedi_device *dev, void *arg, void *file)
> @@ -736,7 +736,7 @@ static int check_insn_config_length(struct comedi_insn *insn,


What warning is this patch resolving?  The original looks correct, a
leading space is fine for something like a comment block like this.

confused,

greg k-h

      reply	other threads:[~2010-05-06  6:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-06  2:39 [PATCH] Staging: comedi: fix coding style issues in comedi_fops.c This patch fixes coding style issues reported by scripts/checkpatch.pl Signed-off-by: Zachary Richey <zr.public@gmail.com> Zachary Richey
2010-05-06  6:22 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100506062232.GA23101@kroah.com \
    --to=greg@kroah.com \
    --cc=fmhess@users.sourceforge.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zr.public@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox