[PATCH] Staging: comedi: fix coding style issues in comedi_fops.c This patch fixes coding style issues reported by scripts/checkpatch.pl Signed-off-by: Zachary Richey <zr.public@gmail.com>

[PATCH] Staging: comedi: fix coding style issues in comedi_fops.c This patch fixes coding style issues reported by scripts/checkpatch.pl Signed-off-by: Zachary Richey <zr.public@gmail.com>

[Zachary Richey]

---
 drivers/staging/comedi/comedi_fops.c |   56 +++++++++++++++++-----------------
 1 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index aca9674..999cbb6 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -598,20 +598,20 @@ copyback:
 static int parse_insn(struct comedi_device *dev, struct comedi_insn *insn,
 		      unsigned int *data, void *file);
 /*
- * 	COMEDI_INSNLIST
- * 	synchronous instructions
- *
- * 	arg:
- * 		pointer to sync cmd structure
- *
- * 	reads:
- * 		sync cmd struct at arg
- * 		instruction list
- * 		data (for writes)
- *
- * 	writes:
- * 		data (for reads)
- */
+*	COMEDI_INSNLIST
+*	synchronous instructions
+*
+*	arg:
+*		pointer to sync cmd structure
+*
+*	reads:
+*		sync cmd struct at arg
+*		instruction list
+*		data (for writes)
+*
+*	writes:
+*		data (for reads)
+*/
 /* arbitrary limits */
 #define MAX_SAMPLES 256
 static int do_insnlist_ioctl(struct comedi_device *dev, void *arg, void *file)
@@ -736,7 +736,7 @@ static int check_insn_config_length(struct comedi_insn *insn,
 		/* by default we allow the insn since we don't have checks for
 		 * all possible cases yet */
 	default:
-		printk("comedi: no check for data length of config insn id "
+		printk(KERN_DEBUG "comedi: no check for data length of config insn id "
 		       "%i is implemented.\n"
 		       " Add a check to %s in %s.\n"
 		       " Assuming n=%i is correct.\n", data[0], __func__,
@@ -894,19 +894,19 @@ out:
 }
 
 /*
- * 	COMEDI_INSN
- * 	synchronous instructions
- *
- * 	arg:
- * 		pointer to insn
- *
- * 	reads:
- * 		struct comedi_insn struct at arg
- * 		data (for writes)
- *
- * 	writes:
- * 		data (for reads)
- */
+*	COMEDI_INSN
+*	synchronous instructions
+*
+*	arg:
+*		pointer to insn
+*
+*	reads:
+*		struct comedi_insn struct at arg
+*		data (for writes)
+*
+*	writes:
+*		data (for reads)
+*/
 static int do_insn_ioctl(struct comedi_device *dev, void *arg, void *file)
 {
 	struct comedi_insn insn;
-- 
1.6.3.3

Re: [PATCH] Staging: comedi: fix coding style issues in comedi_fops.c This patch fixes coding style issues reported by scripts/checkpatch.pl Signed-off-by: Zachary Richey <zr.public@gmail.com>

[Greg KH]

On Wed, May 05, 2010 at 10:39:47PM -0400, Zachary Richey wrote:
> ---
>  drivers/staging/comedi/comedi_fops.c |   56 +++++++++++++++++-----------------
>  1 files changed, 28 insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index aca9674..999cbb6 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -598,20 +598,20 @@ copyback:
>  static int parse_insn(struct comedi_device *dev, struct comedi_insn *insn,
>  		      unsigned int *data, void *file);
>  /*
> - * 	COMEDI_INSNLIST
> - * 	synchronous instructions
> - *
> - * 	arg:
> - * 		pointer to sync cmd structure
> - *
> - * 	reads:
> - * 		sync cmd struct at arg
> - * 		instruction list
> - * 		data (for writes)
> - *
> - * 	writes:
> - * 		data (for reads)
> - */
> +*	COMEDI_INSNLIST
> +*	synchronous instructions
> +*
> +*	arg:
> +*		pointer to sync cmd structure
> +*
> +*	reads:
> +*		sync cmd struct at arg
> +*		instruction list
> +*		data (for writes)
> +*
> +*	writes:
> +*		data (for reads)
> +*/
>  /* arbitrary limits */
>  #define MAX_SAMPLES 256
>  static int do_insnlist_ioctl(struct comedi_device *dev, void *arg, void *file)
> @@ -736,7 +736,7 @@ static int check_insn_config_length(struct comedi_insn *insn,


What warning is this patch resolving?  The original looks correct, a
leading space is fine for something like a comment block like this.

confused,

greg k-h