public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David Rientjes <rientjes@google.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Yinghai Lu <yinghai@kernel.org>,
	Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [patch] x86: fix fake apicid to node mapping for numa emulation
Date: Thu, 6 May 2010 12:01:47 +0200	[thread overview]
Message-ID: <20100506100147.GA19843@elte.hu> (raw)
In-Reply-To: <alpine.DEB.2.00.1005060222560.19473@chino.kir.corp.google.com>


* David Rientjes <rientjes@google.com> wrote:

> On Thu, 6 May 2010, Ingo Molnar wrote:
> 
> > > apicids must be mapped to the lowest node ids to maintain generic kernel use 
> > > of functions such as cpu_to_node() that determine device affinity.
> > > 
> > > Signed-off-by: David Rientjes <rientjes@google.com>
> > > ---
> > >  Third resend of the same patch.
> > > 
> > >  arch/x86/mm/srat_64.c |    3 ++-
> > >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > There's no info in the changelog about what negative effects this bug had when 
> > it was found, on what hardware it occured, and what the general urgency of the 
> > patch is.
> > 
> 
> Ah, true.  Given the relative obscurity of using NUMA emulation to being 
> with, it would probably benefit from being even more verbose as well.  
> I'll rewrite the changelog and reply to this message with it.

Applied to tip:x86/urgent, thanks David!

	Ingo

  parent reply	other threads:[~2010-05-06 10:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05  0:00 [patch] x86: fix fake apicid to node mapping for numa emulation David Rientjes
2010-05-06  7:07 ` Ingo Molnar
2010-05-06  9:24   ` David Rientjes
2010-05-06  9:24     ` [patch v2] " David Rientjes
2010-05-06 10:07       ` [tip:x86/urgent] x86: Fix " tip-bot for David Rientjes
2010-05-06 10:01     ` Ingo Molnar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-03-25 23:19 [patch] x86: fix " David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100506100147.GA19843@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox