public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Kyle McMartin <kyle@mcmartin.ca>
Cc: wzt.wzt@gmail.com, linux-kernel@vger.kernel.org,
	linux-parisc@vger.kernel.org, deller@gmx.de,
	jejb@parisc-linux.org
Subject: Re: [PATCH] Parisc: Check kmalloc return value before use the buffer in ccio-dma.c
Date: Thu, 6 May 2010 04:59:48 -0600	[thread overview]
Message-ID: <20100506105948.GV6747@parisc-linux.org> (raw)
In-Reply-To: <20100506040331.GC4902@bombadil.infradead.org>

On Thu, May 06, 2010 at 12:03:31AM -0400, Kyle McMartin wrote:
> We can change it to GFP_ATOMIC|__GFP_NOFAIL so it will retry infinitely,
> or we can panic in the error path with a nice error message so the users
> knows why his machine isn't going to work.

If we can't initialise the IOMMU, can we even get a panic message out to
the user?

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

  reply	other threads:[~2010-05-06 10:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-06  2:42 [PATCH] Parisc: Check kmalloc return value before use the buffer in ccio-dma.c wzt.wzt
2010-05-06  4:03 ` Kyle McMartin
2010-05-06 10:59   ` Matthew Wilcox [this message]
2010-05-06 20:08     ` Kyle McMartin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100506105948.GV6747@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=deller@gmx.de \
    --cc=jejb@parisc-linux.org \
    --cc=kyle@mcmartin.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=wzt.wzt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox