Re: [PATCH] CHROMIUM: acerhdf: fix bug when running on Qemu

Re: [PATCH] CHROMIUM: acerhdf: fix bug when running on Qemu

[peter]

Quoting Rahul Chaturvedi <rkc@chromium.org>:

> Driver didn't verify the pointers in which it got product information
> back from DMI; on QEMU one of the pointers came back null,
> which made the driver crash and subsequently caused a kernel panic.
>
> Signed-off-by: Rahul Chaturvedi <rkc@chromium.org>
> ---
>  drivers/platform/x86/acerhdf.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index 4d922e4..e8ee3b2 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -500,6 +500,11 @@ static int acerhdf_check_hardware(void)
>  	product = dmi_get_system_info(DMI_PRODUCT_NAME);
>
>
> +	if (!vendor || !version || !product) {
> +		pr_err("error getting hardware information");
> +		return -EINVAL;
> +	}
> +
>  	pr_info("Acer Aspire One Fan driver, v.%s\n", DRV_VER);
>
>  	if (force_bios[0]) {
> --
> 1.7.0.1
>
>

Acked-by: Peter Feuerer <peter@piie.net>

Re: [PATCH] CHROMIUM: acerhdf: fix bug when running on Qemu

[Rahul Chaturvedi]

BTW, the CHROMIUM in the subject is just used for internal bookeeping
for patches not yet accepted upstream.

On Wed, May 5, 2010 at 22:06, Rahul Chaturvedi <rkc@chromium.org> wrote:
> Driver didn't verify the pointers in which it got product information
> back from DMI; on QEMU one of the pointers came back null,
> which made the driver crash and subsequently caused a kernel panic.
>
> Signed-off-by: Rahul Chaturvedi <rkc@chromium.org>
> ---
>  drivers/platform/x86/acerhdf.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index 4d922e4..e8ee3b2 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -500,6 +500,11 @@ static int acerhdf_check_hardware(void)
>        product = dmi_get_system_info(DMI_PRODUCT_NAME);
>
>
> +       if (!vendor || !version || !product) {
> +               pr_err("error getting hardware information");
> +               return -EINVAL;
> +       }
> +
>        pr_info("Acer Aspire One Fan driver, v.%s\n", DRV_VER);
>
>        if (force_bios[0]) {
> --
> 1.7.0.1
>
>

Re: [PATCH] CHROMIUM: acerhdf: fix bug when running on Qemu

[Peter Feuerer]

Rahul Chaturvedi writes:

> BTW, the CHROMIUM in the subject is just used for internal bookeeping
> for patches not yet accepted upstream.

What does it mean? Should I take care about getting it upstream?

--peter;

Re: [PATCH] CHROMIUM: acerhdf: fix bug when running on Qemu

[Mandeep Singh Baines]

Peter Feuerer (pfe@piie.net) wrote:
> Rahul Chaturvedi writes:
>
>> BTW, the CHROMIUM in the subject is just used for internal bookeeping
>> for patches not yet accepted upstream.
>
> What does it mean? Should I take care about getting it upstream?
>

You can drop it. We use it for internal bookkeeping in the chromium
git tree.

http://chromiumos-git/?p=kernel.git

Its useful to us when we rebase our kernel to a new 2.6.x.
We use it to record which tree the patch came from: did it come from
upstream, did we write, did we pull it from a maintainer tree.

> --peter;